Re: Request to review and upload unhide 20210124-4
Hello Fukui (sorry I'm not sure if you prefer to be called Daichi or
Fukui, I'm going by your email signature, but please let me know
otherwise),
All of the changes looks good, but I have a comment about the
Break+Replaces change:
I see that you followed the suggestion from the bug report [0] to go with:
Replaces: unhide (<< 20210124-3)
Breaks: unhide (<< 20210124-3)
But in this specific case, we know that there's only one specific
version which triggers the issue, and that is "20210124-2", as that's
the one that shipped unhide-gui in the unhide package.
In this situation, I recommend us to use the following Breaks+Replaces:
Replaces: unhide (= 20210124-2)
Breaks: unhide (= 20210124-2)
As it only affects testing, and we can remove the whole entry after a
shorter amount of time compared to the usual Breaks+Replaces scenarios
(I think right after the first stable release should be fine).
There's also a new upstream release, which IIRC has 3 patches from
d/patches applied, so we can drop those, would you be interested in
packaging the new release as well?
We can upload all of the changes at once. But please note that if you
don't want to work on the new release, I can upload just a revision
with the current changes you have as they're good (I can change the
Breaks+Replaces if needed).
Thank you for contributing!
[0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1016613
--
Samuel Henrique <samueloph>
Reply to: