Re: Request to review and upload libewf 20140813-1
Hello Daichi,
As Sebastian already explained the situation with the openssl
transition, I'll leave that out of the review.
I'll enumerate things to make discussions easier as we can name them if needed:
1) d/changelog:
The "Closes" stanza should not be present in that changelog entry
because that bug has already been closed on the previous upload.
2) d/tests:
I see that the test present in there is basically the same thing that
autopkgtest-pkg-python does, so I suggest using that.
It's possible that you've tried using it and had issues due to the
test trying to import the wrong module, in order to fix that you'll
need to do what's described in here:
https://manpages.debian.org/testing/autodep8/autodep8.1.en.html#python_(debian/tests/autopkgtest-pkg-python.conf)
And just in case you're not familiar with "autopkgtest-pkg-python",
here's some guidance:
https://wiki.debian.org/Python/LibraryStyleGuide#autopkgtest
Hopefully that will make things simpler.
3) d/copyright:
It's a good idea to improve the copyright entry, as you can see
upstream bumped the years if you look at the diff.
2006-2021, Joachim Metz <joachim.metz@gmail.com>
The entry for "Files: *" can be superseded by this single entry (it's
outdated since a few uploads).
The copyright file is a bit outdated in general, so it would be better
to recheck everything, but it's ok if you only want to change this
part.
Everything else looks fine, we can proceed
Thank you for your contributions!
--
Samuel Henrique <samueloph>
Reply to: