[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Review of fierce



Hi Marcos,

Please:

1. Move the Comment to "Files: *" block and explain about 2007 year.
2. Read carefully all my requests.

Eriberto


Em seg., 13 de abr. de 2020 às 07:18, Marcos Fouces
<marcos.fouces@gmail.com> escreveu:
>
> El dom, 12-04-2020 a las 20:45 -0300, Eriberto escribió:
> > >
> > > It is important to note that the current package is a complete
> > > rewrite.
> > > The original source is Perl code while this one is written in
> > > Python
> >
> > Please, add a Comment field to help the FTP-Masters and to guide
> > other
> > packagers in the future.
>
> Done.
>
> >
> >
> > > > - Please, use the texts from
> > > > /usr/share/debhelper/dh_make/licenses
> > > > for
> > > > license texts. Currently, neither Debian nor FSF uses street
> > > > addresses[2].
> > > >
> > > > [2] https://www.gnu.org/licenses/gpl-3.0.en.html
> > > >
> > > > - In GPL-3 the text must be changed to remove the reference for
> > > > "later version".
> > > >
> > > > - Only to remember, the GPL-3 license text is pointing to GPL-2.
> > >
> > > Done.
> >
> > Not ready. ;-)
> >
> > - The GPL-3 text remains saying about "any later version" but the
> > license is not GPL-3+.
> > - The GPL-2+ text was not updated yet,
>
> I updated both texts from debhelper template and fixed the statement
> about "any later version" to fit with GPL-3.
>
> > > > - (optional) Is a good idea put the license texts after all
> > > > blocks to
> > > > make easier the conference of data. It is good for sponsors and
> > > > FTP-Masters.
> > >
> > > I believe that is already done.
> >
> > What I really meant was put the full license texts (for GPL-3 and
> > GPL2+) after the end of the block "Files: debian/*". It is to make
> > easier the view. Also, please, put the copyright years/names for
> > "Files: *" in chronological order, aligning the names vertically.
> > Please see an example here[10].
>
> Ok, now i get the point. Done.
>
> >
> > Thank you.
> >
> > Eriberto
>
> Thanks again for your time and advice!
>
> Greetings,
> Marcos
>


Reply to: