[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: 2. Reminder: tomb: all open bugs fixed, new upstream version, please review



Hi Sven,

Sven Geuer <debmaint@g-e-u-e-r.de> 於 2019年8月4日 週日 下午5:15寫道:
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> Hello Team,
>
> my latest work on tomb still needs to be reviewed and uploaded. Please
> see my previous mail on this topic, also forwarded below.
>
> I would appreciate receiving some feedback.

Thank you for your efforts, the package has been uploaded to 7-days
delayed queue.

I've skimmed your changes and made some changes [1]

[1] https://salsa.debian.org/pkg-security-team/tomb/tree/debian/master

+  * Remove unnecessary files in .pc
+  * d/control:
+    - Bump Standards-Version to 4.4.0
+  * d/source/lintian-overrides
+    - Remove unnecessary lintian-override

I think it's unnecessary to add that lintian-override, furthermore, the commit
75b44059225136575059477261767468d86aa63f contains multiple changes.
Therefore, this modification cannot be reverted. It would be nice if
you split into
multiple commits next time.

+  * d/upstream/metadata:
+    - Tidy content of metadata

Aside from that, I suggest you send d/patches back to upstream.

SZ

>
> Sven
>
> - -------- Weitergeleitete Nachricht --------
> Von: Sven Geuer <debmaint@g-e-u-e-r.de>
> An: Debian Security Tools Packaging Team <
> debian-security-tools@lists.debian.org>
> Betreff: tomb: all open bugs fixed, new upstream version, please review
> Datum: Thu, 04 Jul 2019 22:30:23 +0200
>
> > Hello Team,
> >
> > I fixed all currently open bugs and packaged the most recent upstream
> > version of tomb [1] which came out during my work. Please review and
> > upload.
> >
> > Because of bug #930782 [2] it should also go into Buster after this
> > is
> > released, I believe. Either with the next point release or via
> > buster-
> > backports. Which is the way to go?
> >
> > These are the changes:
> >
> > tomb (2.6+dfsg1-1) unstable; urgency=medium
> >
> >   * Team upload.
> >   [Sven Geuer]
> >   * New upstream release
> >     - Adapt d/patches/* to new release
> >   * Add further missing dependencies and correct existing ones
> >   * Make package lintian clean
> >     - Add debian/tests/* for autopkgtest
> >     - Add linitian override for unavailabe upstream gpg signature
> >     - Fix for lintian info debian-watch-contains-dh_make-template
> >     - Add patch for three lintian infos spelling-error-in-manpage
> >
> > tomb (2.5+dfsg1-3) UNRELEASED; urgency=medium
> >
> >   * Team upload.
> >   [ Sven Geuer ]
> >   * Add several missing Recommends and Suggests (Closes: #924042).
> >     - gettext-base, lsof, dcfldd, qrencode, unoconv, steghide, swish-
> > e
> >   * d/control:
> >     - Bump Standards-Version to 4.3.0
> >     - Bump DH version to 12
> >   * d/compat:
> >     - Bump compat to 12
> >   * d/copyright:
> >     - Normalize Copyright fields according to DEP-5
> >     - Update * copyright
> >     - Update debian/* copyright
> >   * Add kdf helper binaries to the package (Closes: #924043)
> >     - d/control:
> >       - Change Architecture to 'any'
> >       - Add required Build-Depends and Depends
> >     - Add d/patches/include-kdf-binaries.patch
> >     - d/rules:
> >       - Add overrides for dh_auto_clean/build/install
> >   * Fix default cipher
> >     - Add d/patches/fix-default-cipher.patch (Closes: #930782)
> >     - d/control:
> >       - Correct cipher mentioned in the description
> >   * Fix error messages on opening a new tomb (Closes: #931027)
> >     - Add d/patches/fix-errors-on-open.patch
> >
> > Cheers,
> > Sven
> >
> > [1] https://salsa.debian.org/pkg-security-team/tomb
> > [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=930782
>
>
> -----BEGIN PGP SIGNATURE-----
>
> iQIzBAEBCgAdFiEEPfXoqkP8n9/QhvGVrfUO2vit1YUFAl1GodsACgkQrfUO2vit
> 1YUgcxAAwk0HcqbSUIkwgxJoGdkWmU8LOdqJYaS9BxlP3/DmqoF139mFRFTv1LA+
> YpwYBblGieTU4Q4xtiOhYdhKtzPTVyMq4/NOsL4BMgqEbXJDLWbvxZWvjHuj1R7k
> R32zmFBjk69+Ehe58RLen9+JaiEp1TUKZFrfdc22Ck9fYDwt8wxv2jU/azjJ3kwa
> X/ZNbEXaSzWFYlrKc8YQHUaFfNntEjqkxalKZ4siGFzd7LAOMx8DFTkuVsTsuAho
> Un4tPTUg3CU8h65r6sp6a1dilzw9R3+/eUZbEhDsyPinTqiOaYj1YhLl4vwNFSKW
> +XmJeyw5FG5qN6GAz1tocQXrYzxSiQoBiPS/3k1QBDqMQHWuSWaWX1rLGCAMQ7S2
> qZQJTYPtJZKIeVmIfLh6XFFhMNaXpUG410hxT7DapfSFdZ1AfPpUB1jQSXjQFG8z
> QD3UtLxfu2jz+cKpRV8PrA8mydDfK8qmTp0wZBGToyR9dQvjGcZzfBe1ttKc9jbn
> nXVgDKTjIIx+LBfk2aTgze/E3V54SzdVgJEPH0wVj6zwm/QivIFSwPmfwoAmWp7M
> acFgqPrFOOjRxIPVsUfUV2iOqlBQ+7CFyUAzSJmahUJFMke7UOHHcoAh0GWTwTYH
> 6qzDkVm1ucGV0pHd/sGZsEYCopZG610caByPhb7IUGoH8l1V3po=
> =1yIC
> -----END PGP SIGNATURE-----
>


Reply to: