Re: 2. Reminder: tomb: all open bugs fixed, new upstream version, please review

[Sven Geuer <debmaint@g-e-u-e-r.de>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi SZ,

see inline below ...

Am Donnerstag, den 08.08.2019, 09:42 +0800 schrieb SZ Lin (林上智):
> Hi Sven,
> 
> Sven Geuer <debmaint@g-e-u-e-r.de> 於 2019年8月8日 週四 上午1:58寫道：
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA512
> > 
> > Hi SZ,
> > 
> > ftp-master did not recognize the bugs closed with the previous and
> > unreleased version 2.5+dfsg1-3.
> 
> The package is in DELAYED queue [1] and not accept into unstable yet.
> 
> [1] https://ftp-master.debian.org/deferred.html

And it's listed there with no closed bugs mentioned in the rightmost
column of the table, that is what I was referring too.

> 
> > Are special means required, so that bugs.debian.org will see and
> > process them?
> 
> The bug can be closed by sending email to nnn-done@bugs.debian.org
> [2]
> 
> [2] https://www.debian.org/Bugs/Developer

Normally it is not required to close them by hand as some automatisms
read the bugs to close from the changelog.

As ftp-master didn't detect the bugs to be closed I am afraid these
automatisms will not do their job. I hoped you knew a way to help both
of them (ftp-master + BTS automatisms) to detect the Closes tags in the
changelog. Anyway, the manual approach will work for sure.	

Cheers,
Sven
  
> 
> SZ
> 
> > Sven
> > 
> > Am Mittwoch, den 07.08.2019, 19:30 +0200 schrieb Sven Geuer:
> > > Hi SZ,
> > > 
> > > than you for your review and your suggestions.
> > > 
> > > I did sent the patches to upstream some time ago. They already
> > > found
> > > their way into newer, still unreleased code.
> > > 
> > > Sven
> > > 
> > > Am Mittwoch, den 07.08.2019, 19:11 +0800 schrieb SZ Lin (林上智):
> > > > Hi Sven,
> > > > 
> > > > Sven Geuer <debmaint@g-e-u-e-r.de> 於 2019年8月4日 週日 下午5:15寫道：
> > > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > > Hash: SHA512
> > > > > 
> > > > > Hello Team,
> > > > > 
> > > > > my latest work on tomb still needs to be reviewed and
> > > > > uploaded.
> > > > > Please
> > > > > see my previous mail on this topic, also forwarded below.
> > > > > 
> > > > > I would appreciate receiving some feedback.
> > > > 
> > > > Thank you for your efforts, the package has been uploaded to 7-
> > > > days
> > > > delayed queue.
> > > > 
> > > > I've skimmed your changes and made some changes [1]
> > > > 
> > > > [1]
> > > > https://salsa.debian.org/pkg-security-team/tomb/tree/debian/master
> > > > 
> > > > +  * Remove unnecessary files in .pc
> > > > +  * d/control:
> > > > +    - Bump Standards-Version to 4.4.0
> > > > +  * d/source/lintian-overrides
> > > > +    - Remove unnecessary lintian-override
> > > > 
> > > > I think it's unnecessary to add that lintian-override,
> > > > furthermore,
> > > > the commit
> > > > 75b44059225136575059477261767468d86aa63f contains multiple
> > > > changes.
> > > > Therefore, this modification cannot be reverted. It would be
> > > > nice
> > > > if
> > > > you split into
> > > > multiple commits next time.
> > > > 
> > > > +  * d/upstream/metadata:
> > > > +    - Tidy content of metadata
> > > > 
> > > > Aside from that, I suggest you send d/patches back to upstream.
> > > > 
> > > > SZ
> > > > 
> > > > > Sven
> > > > > 
> > > > > - -------- Weitergeleitete Nachricht --------
> > > > > Von: Sven Geuer <debmaint@g-e-u-e-r.de>
> > > > > An: Debian Security Tools Packaging Team <
> > > > > debian-security-tools@lists.debian.org>
> > > > > Betreff: tomb: all open bugs fixed, new upstream version,
> > > > > please
> > > > > review
> > > > > Datum: Thu, 04 Jul 2019 22:30:23 +0200
> > > > > 
> > > > > > Hello Team,
> > > > > > 
> > > > > > I fixed all currently open bugs and packaged the most
> > > > > > recent
> > > > > > upstream
> > > > > > version of tomb [1] which came out during my work. Please
> > > > > > review
> > > > > > and
> > > > > > upload.
> > > > > > 
> > > > > > Because of bug #930782 [2] it should also go into Buster
> > > > > > after
> > > > > > this
> > > > > > is
> > > > > > released, I believe. Either with the next point release or
> > > > > > via
> > > > > > buster-
> > > > > > backports. Which is the way to go?
> > > > > > 
> > > > > > These are the changes:
> > > > > > 
> > > > > > tomb (2.6+dfsg1-1) unstable; urgency=medium
> > > > > > 
> > > > > >   * Team upload.
> > > > > >   [Sven Geuer]
> > > > > >   * New upstream release
> > > > > >     - Adapt d/patches/* to new release
> > > > > >   * Add further missing dependencies and correct existing
> > > > > > ones
> > > > > >   * Make package lintian clean
> > > > > >     - Add debian/tests/* for autopkgtest
> > > > > >     - Add linitian override for unavailabe upstream gpg
> > > > > > signature
> > > > > >     - Fix for lintian info debian-watch-contains-dh_make-
> > > > > > template
> > > > > >     - Add patch for three lintian infos spelling-error-in-
> > > > > > manpage
> > > > > > 
> > > > > > tomb (2.5+dfsg1-3) UNRELEASED; urgency=medium
> > > > > > 
> > > > > >   * Team upload.
> > > > > >   [ Sven Geuer ]
> > > > > >   * Add several missing Recommends and Suggests (Closes:
> > > > > > #924042).
> > > > > >     - gettext-base, lsof, dcfldd, qrencode, unoconv,
> > > > > > steghide,
> > > > > > swish-
> > > > > > e
> > > > > >   * d/control:
> > > > > >     - Bump Standards-Version to 4.3.0
> > > > > >     - Bump DH version to 12
> > > > > >   * d/compat:
> > > > > >     - Bump compat to 12
> > > > > >   * d/copyright:
> > > > > >     - Normalize Copyright fields according to DEP-5
> > > > > >     - Update * copyright
> > > > > >     - Update debian/* copyright
> > > > > >   * Add kdf helper binaries to the package (Closes:
> > > > > > #924043)
> > > > > >     - d/control:
> > > > > >       - Change Architecture to 'any'
> > > > > >       - Add required Build-Depends and Depends
> > > > > >     - Add d/patches/include-kdf-binaries.patch
> > > > > >     - d/rules:
> > > > > >       - Add overrides for dh_auto_clean/build/install
> > > > > >   * Fix default cipher
> > > > > >     - Add d/patches/fix-default-cipher.patch (Closes:
> > > > > > #930782)
> > > > > >     - d/control:
> > > > > >       - Correct cipher mentioned in the description
> > > > > >   * Fix error messages on opening a new tomb (Closes:
> > > > > > #931027)
> > > > > >     - Add d/patches/fix-errors-on-open.patch
> > > > > > 
> > > > > > Cheers,
> > > > > > Sven
> > > > > > 
> > > > > > [1] https://salsa.debian.org/pkg-security-team/tomb
> > > > > > [2] 
> > > > > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=930782
> > > > > 
> > > > > -----BEGIN PGP SIGNATURE-----
> > > > > 
> > > > > iQIzBAEBCgAdFiEEPfXoqkP8n9/QhvGVrfUO2vit1YUFAl1GodsACgkQrfUO2
> > > > > vit
> > > > > 1YUgcxAAwk0HcqbSUIkwgxJoGdkWmU8LOdqJYaS9BxlP3/DmqoF139mFRFTv1
> > > > > LA+
> > > > > YpwYBblGieTU4Q4xtiOhYdhKtzPTVyMq4/NOsL4BMgqEbXJDLWbvxZWvjHuj1
> > > > > R7k
> > > > > R32zmFBjk69+Ehe58RLen9+JaiEp1TUKZFrfdc22Ck9fYDwt8wxv2jU/azjJ3
> > > > > kwa
> > > > > X/ZNbEXaSzWFYlrKc8YQHUaFfNntEjqkxalKZ4siGFzd7LAOMx8DFTkuVsTsu
> > > > > Aho
> > > > > Un4tPTUg3CU8h65r6sp6a1dilzw9R3+/eUZbEhDsyPinTqiOaYj1YhLl4vwNF
> > > > > SKW
> > > > > +XmJeyw5FG5qN6GAz1tocQXrYzxSiQoBiPS/3k1QBDqMQHWuSWaWX1rLGCAMQ
> > > > > 7S2
> > > > > qZQJTYPtJZKIeVmIfLh6XFFhMNaXpUG410hxT7DapfSFdZ1AfPpUB1jQSXjQF
> > > > > G8z
> > > > > QD3UtLxfu2jz+cKpRV8PrA8mydDfK8qmTp0wZBGToyR9dQvjGcZzfBe1ttKc9
> > > > > jbn
> > > > > nXVgDKTjIIx+LBfk2aTgze/E3V54SzdVgJEPH0wVj6zwm/QivIFSwPmfwoAmW
> > > > > p7M
> > > > > acFgqPrFOOjRxIPVsUfUV2iOqlBQ+7CFyUAzSJmahUJFMke7UOHHcoAh0GWTw
> > > > > TYH
> > > > > 6qzDkVm1ucGV0pHd/sGZsEYCopZG610caByPhb7IUGoH8l1V3po=
> > > > > =1yIC
> > > > > -----END PGP SIGNATURE-----
> > > > > 
> > -----BEGIN PGP SIGNATURE-----
> > 
> > iQIzBAEBCgAdFiEEPfXoqkP8n9/QhvGVrfUO2vit1YUFAl1LEQAACgkQrfUO2vit
> > 1YWTIA/9HgGUrlrQ88knWB33S1j76Q4Qskahkw5JFLP6rBIKGB+7Z2kgOxC8upRB
> > hfxQuT7lVmZp1CC8B0NVd5M9/odmzBECGjVhaYCzJDHXeFDH2O/vczUpyZdVu7rY
> > DY9Zei1x2uMrAOCuA6cclPww7EBB+2OFpKLIF8JcbTaamrY84tq5Ym3Sn5xXiFok
> > FCzqzAfHzyClw+v9Cbfj0nkUGkf3ZcAIRoOGg+T1EgUfIQGRtMd2LAJbgfIRsdwL
> > 7saVOL6IReq5P0mEHTbA8QvcCTbHuSweLuBjx+R2CZyKAFZkIZxsN5j19SRAEc8m
> > RbaVJlnPMFb/aVMkuqnvznyrbVjEuF02KK8xWbIAwqoYnpFpPxpDW8k3t4Tu8koU
> > d680FipBXEm/08tYgSiLefmgBljw3p2Lfh4jG6oPSTlbmuPPZlrh9oBeBcCLi/ri
> > o6XDuu1Qv1luwjOZmlQY1ejgRZ7ApR0VrGwISCiXkEgBp2KwbqxZjBzYEiQ+CUsw
> > EQXafmvO5A4xEopnf/wS82NDQ4BI8PnnHWKq1A0SBp9I03kwHXTxoF9D+xb7UXAR
> > /2DzBpey8fli8fEYynSQCA18ONOIX9dW0Lb7QZP89IyX/FQLgMQtg5UxvNgjYGER
> > HpT3ZMX2hk80OzezE6OfelDIojQqQ1L8qtoxi1VyL/yDwOA/HWw=
> > =8svK
> > -----END PGP SIGNATURE-----
> > 
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEPfXoqkP8n9/QhvGVrfUO2vit1YUFAl1MWawACgkQrfUO2vit
1YVxsQ//SGaqih/9Q/rIz/jmSJsOWp1ZMFctx7OVav5BlX19jgiMjxQrfV1dxkfq
PUzQkajl4lG/5KKnju2XkM0M7YVz3ovozpU+QrD+Vn8SvAG4DnedCtZyI+iDMNRO
x9qg3jrztgezVTxOhj7KaNyxptoHjTV3uKx8o6oL8ottdFhBc3XpW03wwLbLUQ0z
oPjUAfpZeS/16aSdKJ230cBs4AeF2vN/8cVIGgJHovXngwy5axdDk01KiO4c8J6y
QmnBPOLTMHteLKq7G+wJuRlO7pa79aCy1nivGhzeiKbMtqyPvdGYht9Uytvo1jUl
VOnOiJpdCllhQsVIenXB3MQH/ljQesogBfU+v9YJDhcAwZng0LZHHX3xnmbOuff6
/hW+/UYazRGMk+ORwvlwtOsvshC8Q84jHy6M3BNvDZrduZ6Y65bVYGukPZuCpsZe
Wl1QJK4KYmnpYhaZFCRmUVgymb132D0M56R68zgwPTyBx657dZAv6oDGBWh+vvrQ
PWzZozCHFGzP+JMKW1T5Gu/UHVV5L62F2YqACTG8sT9LnsfSnosZIPlk8+8l7EQ4
eZJgNmwnPbzV2O+3eLb7dRG9zuw9anaKUAPf45MdVfg3XEBRJ9I5vyANjzk82c0r
B1pluvluUSNBlZLibePWi96lXaqCtaNYw0cEUJIOk1qDHPATGKM=
=lp/Z
-----END PGP SIGNATURE-----