Re: brutespray / curvedns / ledger-wallets-udev updates
Hello Stéphane,
On Sat, 07 Jul 2018, Stéphane Neveu wrote:
> Hi all !
> I've updated brutespray, curvedns to correct bugs 903076 and 903064
> and also ledger-wallets-udev (updated Build-Depends: ruby-ronn ->
> ronn)
Thanks for this. A few comments:
* the changelog entries that you added were malformed, they were lacking
the signature line, please use "dch" or better "gbp dch" to generate them
* brutespray and ledger-wallets-udev were lacking the bug closure in their
changelog entry
* brutespray and curvedns were lacking the changelog entries for the
Vcs-Git/Vcs-Browser changes that had been committed but never released
yet
In general, I advise you to write good commit message including a bug
closure line at the end, and then use "gbp dch" to generate/update the
changelog. This will avoid the simple mistakes you made here. And it will
also means that bugs are properly tagged as pending as soon as you push
your commits (thanks to the hook that we have configured on salsa).
And since you don't modify debian/changelog in each commit, it also means
that your commit can be more easily be cherry-picked between different
branches.
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/
Reply to: