Re: DD Ping

[Marcos Fouces <marcos.fouces@gmail.com>]

Hello Samuel

Thanks for your review. I followed all your advices so i believe that
packages are ready to upload.

Greetings,

Marcos


On 03/11/18 09:15, Samuel Henrique wrote:
> Hello Marcos,
>
> Here's my review:
>
> dsniff:
>  - d/changelog: In one of the commits you introduced a trailing
> whitespace at #4
>  - d/copyright: has trailing whitespaces at #10 and #22
>  - d/rules: theres a tab at #8 which can be removed
>
>  - if you use vim, adding this to your .vimrc will make it easier to
> spot these kind of things:
>
>     " highlight trailing whitespaces
>     highlight ExtraWhitespace ctermbg=red guibg=red
>     match ExtraWhitespace /\s\+$/
>
>
> libnids:
>  - I see you changed Section of the package libnids1.21 at this
> commit:
> https://salsa.debian.org/pkg-security-team/libnids/commit/6bf1e38caa6c0047140dcd339b1cbb8db0b5e93c
>    Please be aware that after the upload is made, you will have to
> submit a request to override the existing section because the package
> is already in Debian with a different section:
>   
> https://www.debian.org/doc/manuals/developers-reference/ch05.en.html#override-file
>  - I would recommend creating a better changelog entry other than "Set
> proper package section name", you can use that line to tell exactly
> what you've made, something like "Change Section of libnidsX.XX to libs"
>
> Other than that, changes on both packages are ok and I would be happy
> to sponsor them for you, since we are approaching freeze, this type of
> housekeeping is very appreciated, especially if there was no upload
> after switching to salsa.
>
> Regards,
>
> -- 
> Samuel Henrique <samueloph>