> d/watch: ok
> d/control: ok, but it's better with wrap-and-sort
I don't really like the warp-and-sort style for listing the
Build-Dependencies. Having the first b-d on a new line and all of them
with a trailing comma gives a lot more readable git diffs. If you
insist I'll change it through.
Not at all, I won't complain if you don't want to, personally I rather have it one per line because I find the git diff better this way, I thought you'd find it too.
The package is FTBFSing for me randomly, I'm building it with sbuild on a amd64 with 8 cores and 16gb ram, here is the error:
8/8 Test #5: test_live_validation .............***Failed 20.01 sec
(2018/11/03 07:35:58:333920): RTR_MGR: rtr_mgr_start()
(2018/11/03 07:35:58:334056): RTR Socket: State: RTR_CONNECTING
(2018/11/03 07:35:58:644796): TCP Transport(rpki-validator.realmv6.org:8282): Connection established
(2018/11/03 07:35:58:644806): RTR_MGR: Group(1) status changed to: RTR_MGR_CONNECTING
(2018/11/03 07:35:58:644808): RTR Socket: State: RTR_RESET
(2018/11/03 07:35:58:644809): RTR Socket: Sending reset query
(2018/11/03 07:35:58:644827): RTR Socket: rtr_start: reset pdu sent
(2018/11/03 07:35:58:644828): RTR_MGR: Group(1) status changed to: RTR_MGR_CONNECTING
(2018/11/03 07:35:58:644830): RTR Socket: State: RTR_SYNC
(2018/11/03 07:35:58:952116): RTR Socket: enc_pdu_len: 8
(2018/11/03 07:35:58:952127): RTR Socket: err_msg_len: 0
(2018/11/03 07:35:58:952129): RTR Socket: Error PDU received
(2018/11/03 07:35:58:952131): RTR Socket: Client uses unsupported protocol version
(2018/11/03 07:35:58:952132): RTR Socket: Downgrading from 1 to version 0
(2018/11/03 07:35:58:952134): RTR_MGR: Group(1) status changed to: RTR_MGR_CONNECTING
(2018/11/03 07:35:58:952137): RTR Socket: State: RTR_FAST_RECONNECT
(2018/11/03 07:35:58:952154): TCP Transport(rpki-validator.realmv6.org:8282): Socket closed
(2018/11/03 07:35:58:952157): RTR_MGR: Group(1) status changed to: RTR_MGR_CONNECTING
(2018/11/03 07:35:58:952158): RTR Socket: State: RTR_CONNECTING
(2018/11/03 07:35:59:260426): TCP Transport(rpki-validator.realmv6.org:8282): Connection established
(2018/11/03 07:35:59:260439): RTR_MGR: Group(1) status changed to: RTR_MGR_CONNECTING
(2018/11/03 07:35:59:260441): RTR Socket: State: RTR_RESET
(2018/11/03 07:35:59:260443): RTR Socket: Sending reset query
(2018/11/03 07:35:59:260459): RTR Socket: rtr_start: reset pdu sent
(2018/11/03 07:35:59:260461): RTR_MGR: Group(1) status changed to: RTR_MGR_CONNECTING
(2018/11/03 07:35:59:260462): RTR Socket: State: RTR_SYNC
(2018/11/03 07:35:59:782620): RTR Socket: Cache Response PDU received
88% tests passed, 1 tests failed out of 8
Total Test time (real) = 20.01 sec
The following tests FAILED:
5 - test_live_validation (Failed)
Errors while running CTest
make[1]: *** [Makefile:122: test] Error 8
make[1]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
dh_auto_test: cd obj-x86_64-linux-gnu && make -j8 test ARGS\+=-j8 returned exit code 2
I tried building a few times to get the probability of a failed build and got 6 fails out of 13 attempts.
I think this will have to be fixed before uploading the package, let me know if you're able to replicate on your machine.
Thanks