intetsim review (Re: ITP: inetsim)
Hi GengYu,
[dropped upstream from CC since my comments are about the Debian
package and do not seem relevant for them]
Changes look mostly good so far! I have a few comments to them:
* you dropped all the perl library dependencies; You might still need
(please check!): libnet-server-perl, libnet-dns-perl,
libipc-shareable-perl, libio-socket-ssl-perl
* inetsim.postinst: It's conventional to have the code guarded by an
"if" statement indented; that improves readability a lot.
* helper script: when you added "exec", you dropped "$@"; however, "$@"
is still needed, otherwise any parameters passed to the helper
script are not preserved when calling the real script!
* changelog:
- "forked" from kali is not really true: Kali will automatically
import Debian's version in favor of its own once it's uploaded!
That's one of the beautiful things in working for Debian: Not only
Debian's users will benefit from your work, but a whole lot of
downstream distributions as well :) . So I'd rather call it
"imported from Kali". Forked has a negative touch to it (at least
to me), because it usually involves splitting a project and
duplicating work.
- since you decided to preserve Kali's changelog, you should document
all the changes you made since the last Kali version as well
More comments follow inline below.
On Thu, 5 Oct 2017 11:19:31 +0000
yoo z <zouyoo at outlook.com> wrote:
> ?I think we should ask the upstream author about the .exe files
> because this is a tool for malware analysis, it included these
> harmless samples.
If the .exe is useful:
* You need to recompile it from source for the Debian package (this
will require an additional build dependency on a C compiler that can
produce windows binaries, like i686-w64-mingw32-gcc from the
gcc-mingw-w64-i686 package, and a modification of debian/rules to
actually compile it).
* If it is not used automatically by inetsim, explain how it can/should
be used.
Btw, there is also a sample_gui.c / sample_gui.exe for which the same
might apply.
> I've added the inetsim.init script now, which is the same with
> contrib/init.d.inetsim
If you want to use upstream's init script, you should not make a copy
of it in the "debian" directory. Instead, use debian/inetsim.install to
place it in the correct location. Otherwise you might not notice it if
upstream changes the init script (and still install the old one).
> > * in any case, the contents of this directory and its use should be
> > explained (also for filter-logs.pl and gen_control.pl); I would
> > suggest creating a README.Debian for that
> >
> ?these two scripts were written by the upstream author to simplify
> the usage (one for log file. one for ip config)
> I'll add a README.Debian after upstream give us advice about these
> files
Ok :) .
Thanks for for your work on inetsim & have a nice evening
Lukas
Reply to: