[pkg] CurveDNS - review
- Subject: [pkg] CurveDNS - review
- From: lukas@schwaighofer.name (Lukas Schwaighofer)
- Date: Sat, 1 Jul 2017 14:43:51 +0200
- Message-id: <[🔎] 20170701144351.677cee5b@localhost>
- In-reply-to: <CAFG-WzBdnuPxMe0H4rp7oqoWBGD7wgOAgiQp9JhVNmWwVS3CTw@mail.gmail.com>
- References: <CAFG-WzBr1tHq8frUzBoaU7bvBJ3JG_y_-O0TV=qX8txqpNH6dg@mail.gmail.com> <20170626000438.490d581f@localhost> <CAFG-WzDcpNmw_KvQ6r-TFoG7m0in9TimQwUwu=rTT_P6CG1MWw@mail.gmail.com> <20170627002800.489aa23d@localhost> <CAFG-WzCWLRVMysmXN8igJ4f_qcg10N0T=wP2YABcNZfJX1zmNw@mail.gmail.com> <E1dPsCa-00084m-UT@moszumanska.debian.org> <CAFG-WzDkvOG9t6ODREOS+P0XW8jD-xt6JdS7nVaxRMPxABuw-A@mail.gmail.com> <20170627230008.3f8b466b@localhost> <CAFG-WzCbAoQ=etRojGSh5qqhy816EYeJ0+asixG8wzVBvcc+Hg@mail.gmail.com> <20170628204131.284349e9@localhost> <CAFG-WzAk5vNh-6QnzFR5+pSWDqiVW6979Ad4XUbhp-ziwUA6Dg@mail.gmail.com> <20170628223123.081c4151@localhost> <CAFG-WzBpGfOAP=fpoMgLmPxDX801xQRtf7ED_Fx8xEMdOx1usQ@mail.gmail.com> <20170629100238.293462b4@localhost> <CAFG-WzBD6znmQJs1=WfjcKb58eLrxyExV6oBXgfXk=gyr96=9A@mail.gmail.com> <20170629225934.410b8234@localhost> <CAFG-WzBdnuPxMe0H4rp7oqoWBGD7wgOAgiQp9JhVNmWwVS3CTw@mail.gmail.com>
Hi Stephane,
I've made a thorough pass over the package again and made a few
changes, most of them minor things like wording.
Noteworthy stuff I've changed:
* I've removed README and INSTALL again as they are not useful for the
Debian package (I know you included them at my request earlier, sorry
about that)
* I've cleaned a bit of unnecessary stuff from the makefile and
re-introduced the `distclean` target (used by dh_clean to remove
the compiled files)
* I've changed debian/rules so that the generated man pages are cleaned
as well (the clean target now properly removes everything that was
generated)
* Changes to postinst:
- /var/lib/curvedns and the curvedns user is already cleaned on
"remove" (it's not configuration?)
- the configuration in /etc/curvedns/ is still only cleaned on "purge"
* I've changed the man pages a bit. In particular I've removed the
example output (I'm always afraid someone will copy it and use it as
their key?)
Please review my changes. I have no more comments now :) .
If you are happy with my changes then I suggest you update the
timestamp in debian/changelog and then ask if one of the DDs here is
willing to review (and hopefully sponsor) the package.
Regards
Lukas
PS: Don't forget to submit a pull request upstream to fix the spelling
mistakes.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-security-team/attachments/20170701/06c82bd3/attachment.sig>
Reply to: