Ask for review
On Thu, 15 Jun 2017, Raphael Hertzog wrote:
> I started to review and sponsor the various packages.
I sponsored rfdump as-is.
Continuing my review, looking at snoopy now:
1/ Has "snoopy" been tested ?
I see this in the postinst:
# is snoopy already in $PRELOADFILE?
test -f $PRELOAD && grep "$LIBNAME" $PRELOAD && exit 0
That will fail if $PRELOAD does not exist or if it doesn't contain
$LIBNAME. Given "set -e" the whole postinst will fail... and thus
dpkg-reconfigure will never work to add or remove libsnoopy.so from
/etc/ld.so.preload.
2/ The prerm uses #!/bin/bash. Why not #!/bin/sh? I see no bashism AFAIK.
3/ debian/README.Debian needs to be updated as the instruction to manually
enable is wrong.
4/ I had to add "socat" to Build-Depends to get the package to build (you
should really do test builds with sbuild or pbuilder in minimal chroots).
5/ I dropped the lintian override for binary-without-manpages. You can
ignore those warnings but it's bad practice to hide them.
Please fix the various issues, test the package and ping me again when
it's ready.
--
Rapha?l Hertzog ? Debian Developer
Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/
Reply to: