[Pkg-security-team] [t50] 02/05: Remove -pie explicit flag It is already passed as hardening+=all.

[hertzog@debian.org (Raphael Hertzog)]

Hello Samuel,

On Fri, 26 Aug 2016, Samuel Henrique wrote:
> commit a98efd4f46277440150dfb992165e7af714a7477
> Author: Samuel Henrique <samueloph at gmail.com>
> Date:   Thu Aug 25 22:11:50 2016 -0300
> 
>     Remove -pie explicit flag
>      It is already passed as hardening+=all.

Please respect the git conventions to format git commit logs.
One line summary. One empty line. Then a long description.

> -export DEB_BUILD_MAINT_OPTIONS = hardening=+all,-pie
> +export DEB_BUILD_MAINT_OPTIONS = hardening=+all

Then I believe this commit to be wrong, or at least your description is
wrong.

"-pie" disables -fPIE while "+all" enables it... so it's not redundant,
that was the correct syntax to say "enable everything except -fPIE".

But if it works with -fPIE then there's no reason to disable it for sure.
I did not check that.

Cheers,
-- 
Rapha?l Hertzog ? Debian Developer

Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/