bbqsql_1.1-2_amd64.changes REJECTED
Hi,
On Wed, 09 Nov 2016, Marcos Fouces wrote:
> Hi Rapha?l
>
> I added a copyright notice for bbqsql/menu* files to give credits to SET.
> I did not see any other credits on the sources.
You missed at least the entry that Chris Lamb pointed in his reject mail.
Also you dropped my nicer formatting of the copyright file.
I fixed the copyright file like I wanted to and I also fixed a bunch of
other things that I missed in my initial review like the bad
"Architecture: any" (should be all). Check out the git repository for the
details.
I also bumped to debhelper 10 to please Samuel. :)
Cheers,
> El 09/11/16 a las 21:01, Raphael Hertzog escribi?:
> > Hi Chris,
> >
> > On Wed, 09 Nov 2016, Chris Lamb wrote:
> > > Looks like d/copyright isn't completely up to date, eg.:
> > I understand a reject when we miss a license or misclassify files
> > according to their license... but AFAIK we do not require to capture
> > all copyright holders in debian/copyright.
> >
> > Am I wrong?
> >
> > Even upstream stopped doing it, replacing the copyright
> > notice by a generic one: "Copyright 2012, BBQSQL All rights reserved."
> > (followed by BSD-3-Clause).
> >
> > Anyway, Marcos, can you review the copyright file to include all the
> > copyright notices in the generic "Files: *" entry? (No need to create
> > sub-set like "bbqsql/menu/*" since all files have the same license)
> >
> > Thank you!
> >
> > > bbqsql/__init__.py
> > > __copyright__ = 'Copyright 2012 Ben Toews (mastahyeti)'
> > >
> > > bbqsql/menu/LICENSE.md
> > > Copyright 2011, The Social-Engineer Toolkit (SET)
> > >
> > > (Stopped looking at this point; there might be others)
> > >
> > > -- Chris Lamb <lamby at debian.org> Wed, 09 Nov 2016 17:51:09 +0000
> > >
> > >
> > >
> > > ===
> > >
> > > Please feel free to respond to this email if you don't understand why
> > > your files were rejected, or if you upload new files which address our
> > > concerns.
> > >
> > >
> > >
>
--
Rapha?l Hertzog ? Debian Developer
Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/
Reply to: