Update watch files for polenum and acccheck
Hello Rapha?l,
Thanks for the uploads.
BTW. Is there something wrong with acct package?
Greetings,
Marcos
El 08/11/16 a las 15:53, Raphael Hertzog escribi?:
> Hello Marcos,
>
> sorry for the delay.
>
> On Mon, 24 Oct 2016, Marcos Fouces wrote:
>> All three packages are (hopefully) ready for upload.
> Uploaded polenum, acccheck and sucrack.
>
>> BTW, there is also acct and bbqsql packages waiting.
> Looking at bbqsql, it's good, so I uploaded it.
>
> Looking at acct, it's definitely not good to go. You merged patches
> from the BTS without any critical review... not everything that
> is submitted are good ideas. Sometimes bug reporters suggest ugly work
> arounds...
>
> Commenting on commits:
> 3747373540d0ea8402e102982843b35fe7ba768b More robust cron.daily.
>
> => you dropped the most important line: the one calling "savelog"
>
> ca6e05f26923ef32f7616bf2d8c25b44c2bfd922 Fix broken cron.monthly
>
> => the bug reporter basically reverted the change of the maintainer
> at that time, it was certainly broken but I would still keep some
> of the improvements like the early exit when "/usr/bin/accton" does
> not exist (instead of the big "if)
>
> even better would be to work with the logrotate maintainer to get
> a hook into a "prerotate" script associated to wtmp handling. Because
> this script is really hackish.
>
> 4fe61651c1088c87fc3c31b9a9c84f6915f99eeb keep stopping and starting acct
>
> => this is definitely not a good fix, if the problem reported is true,
> then it needs to be fixed at the glibc or kernel level, I suspect the
> problem does no longer exist as we haven't gotten many "me too" in years
> in that old bug report. Please revert that change and close the bug.
>
> The other changes looked fine from a cursory look. Did you test the
> package?
Reply to: