[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Building Magma with AMD GPU support



Hi Mo,

I've opened an MR on Salsa with an extremely rough initial draft of the package update for magma-rocm [1]. I'm still a little fuzzy on some conventions, so I'm sure there's lots of stuff to change. Nevertheless, I think it's a useful starting place for further discussion.

On 2024-12-19 16:40, Mo Zhou wrote:
As you may have noticed, src:pytorch (main) and src:pytorch-cuda (contrib) is the identical source but uploaded twice due to the difference in their sections. This is found to minimize my effort compared to maintaining two separate sources, especially when I need to apply the same logic to many other packages like src:gloo, src:tensorpipe, etc.

For magma I'd personally prefer my own approach. Maybe you can just refer to the debian/cudabuild.sh and debian/rocmbuild.sh from src:pytorch, and see whether this works for you. In that sense we can avoid duplicated working repository which is nothing but requiring double human effort. Namely, a debian/rocmbuild.sh conversion script, and a control.rocm file targeting at Section: main should be good to go.

If the documentation is identical for both the ROCm and CUDA versions of magma, do we want to just move libmagma-doc from contrib into main instead of creating a new libmagma-rocm-doc package? I suppose if the ROCm and CUDA versions of the package are different versions, you might want to be able to install both versions of the docs, but it does seem a bit odd to have two practically identical packages. I could see a case for doing it either way.

Sincerely,
Cory Bloor

[1]: https://salsa.debian.org/science-team/magma/-/merge_requests/1


Reply to: