[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Help needed for cmake in sfst



Thanks a lot, works!

Am Mon, Dec 16, 2024 at 08:03:37AM +0100 schrieb Maarten L. Hekkelman:
> The problem is the add_subdirectory in the CMakeLists.txt file for pybind11
> and python. They should be removed.
> 
> Here's a pybind11.patch file that works:
> 
> --- a/python/CMakeLists.txt
> +++ b/python/CMakeLists.txt
> @@ -13,6 +13,11 @@
>  set(CPACK_PROJECT_VERSION ${PROJECT_VERSION})
>  include(CPack)
> 
> +cmake_policy(SET CMP0148 NEW)
> +
> +set(PYBIND11_FINDPYTHON ON)
> +find_package(pybind11 REQUIRED)
> +
>  pybind11_add_module(sfst
>      sfst.cpp
>  )
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -16,7 +16,3 @@
> 
>  # add library code
>  add_subdirectory(src)
> -
> -# add python bindings
> -add_subdirectory(pybind11)
> -add_subdirectory(python)
> 
> 
> Hope this helps.
> 
> -maarten
> 
> 
> Op 13-12-2024 om 12:28 schreef Andreas Tille:
> > Hi,
> > 
> > I intended to upgrade sfst to latest upstream to fix bug #1079107 but
> > there are some cmake list related changes which make the build fail[1].
> > I tried a bit in some patch[2] but this just changed the error in some
> > way without solving it.
> > 
> > Any help is welcome
> >     Andreas.
> > 
> > 
> > [1]https://salsa.debian.org/science-team/sfst/-/jobs/6746739#L1227
> > [2]https://salsa.debian.org/science-team/sfst/-/blob/master/debian/patches/pybind11.patch?ref_type=heads
> > 
> 
> -- 
> Maarten L. Hekkelman
> https://www.hekkelman.com/
> 
> 

-- 
https://fam-tille.de


Reply to: