Re: Bug#949767: arrayfire update fails in configure step

[Gard Spreemann <gspr@nonempty.org>]

Andreas Tille <andreas@an3as.eu> writes:

> Hi Gard,
>
> On Wed, Apr 28, 2021 at 06:08:25PM +0200, Gard Spreemann wrote:
>> >>
>> >> libclblast-dev ships
>> >>
>> >>  /usr/lib/x86_64-linux-gnu/cmake/CLBLast/CLBlastConfig.cmake
>> >>
>> >> Notice that there's both "CLBLast" and "CLBlast" in there! I'll
>> >> investigate.
>> >
>> > Looks like an upstream bug; consider the inconsistent capitalization of
>> > the second l in "clblast" online 363 in
>> >
>> >  https://salsa.debian.org/gspr/clblast/-/blob/54e86eec37593623a5f692a39d78355043a402ad/CMakeLists.txt#L363
>> >
>> > I'll report it upstream and patch src:clblast.
>> 
>> Could you try with the patch from the debian/gspr/typo branch of [1]?
>> Alternatively, I put a built version of the patched clblast up at [2].
>
> With
>
>
> diff --git a/debian/control b/debian/control
> index 5fbc359b..edeceaa7 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -19,7 +19,7 @@ Build-Depends: cmake,
>                 libspdlog-dev,
>                 opencl-clhpp-headers,
>                 libclfft-dev,
> -               libclblast-dev
> +               libclblast-dev (>= 1.5.2-1+test1)
>  Build-Depends-Indep: doxygen
>  Standards-Version: 4.5.1
>  Vcs-Browser: https://salsa.debian.org/science-team/arrayfire
>
>
> I get
>
> ...
> -- Found OpenCL: /usr/lib/x86_64-linux-gnu/libOpenCL.so (found version "2.0").
> CMake Warning at CMakeModules/build_CLBlast.cmake:8 (find_package):
>   By not providing "FindCLBLast.cmake" in CMAKE_MODULE_PATH this project has
>   asked CMake to find a package configuration file provided by "CLBLast", but
>   CMake did not find one.
>
>   Could not find a package configuration file provided by "CLBLast" with any
>   of the following names:
>
>     CLBLastConfig.cmake
>     clblast-config.cmake
>
>   Add the installation prefix of "CLBLast" to CMAKE_PREFIX_PATH or set
>   "CLBLast_DIR" to a directory containing one of the above files.  If
>   "CLBLast" provides a separate development package or SDK, be sure it has
>   been installed.
> Call Stack (most recent call first):
>   src/backend/opencl/CMakeLists.txt:434 (include)
>
>
> I'm not sure whether I understood your hint correctly.

The capitalization typo seems to be present also in arrayfire's
use_debian_packaged_libs.patch: I believe line 64 of

 https://salsa.debian.org/science-team/arrayfire/-/blob/a11a6fef7dadf8ce594920626058990fe0caeb2a/debian/patches/use_debian_packaged_libs.patch#L64

should read

 +find_package(CLBlast)

instead of

 +find_package(CLBLast)

as it currently does.

> BTW, It would be great if [1] would feature a pristine-tar branch.

I'll look into creating pristine-tar branches for my packages. Thanks
for the nudge!


 Best,
 Gard