Re: RFS: macaulay2

["Torrance, Douglas" <dtorrance@piedmont.edu>]

Hi Julien,

On 8/3/20 6:41 AM, Julien Puydt wrote:
> Le dimanche 02 août 2020 à 16:47 +0000, Torrance, Douglas a écrit :
>> On 8/2/20 2:25 AM, Julien Puydt wrote:
>>> You should re-check everything and tell me when to review again.
>>
>> Thanks for the review!
>>
>> I asked Mahrud and he confirmed that it is indeed the 3-clause BSD
>> license.  I've added a comment clarifying this, and have also
>> separated
>> out the cmake files with additional authors into their stanzas.
>>
>> I also went back through and re-checked everything else in
>> d/copyright.
>> I had missed the .m4 files in M2/config and a handful of other
>> files.  I
>> think everything is in good shape now if you'd like take another
>> look.
> 
> You missed the files:
> 
> - M2/Macaulay2/e/franzi* : they are from Franziska Hinkelmann in the
> public domain ;
> 
> - M2/Macaulay2/editors/vim/m2.vim.plugin from David Cook II in the
> public domain ;
> 
> - M2/Macaulay2/editors/vim/m2.vim.syntax and
> M2/Macaulay2/editors/vim/README_* are from Manoj Kummini, no license
> (!) ;
> 
> - M2/Macaulay2/m2/expressions.m2 was rewritten in 2018 by P. Zinn-
> Justin ;
> 
> - M2/Macaulay2/m2/hypertext.m2 was rewritten in 2020 by P. Zinn-Justin
> and Mahrud Sayrafi ;
> 
> - M2/Macaulay2/m2/localring.m2 has more authors ;
> 
> - M2/Macaulay2/m2/minPres.m2 is from Amelia Taylor ;
> 
> - M2/Macaulay2/m2/schubert.m2 is from Bernd Sturmfels and Josephine Yu
> ;
> 
> - M2/Macaulay2/m2/webapp.m2 is from Paul Zinn-Justin 2018 ;
> 
> - M2/Macaulay2/tests/normal/ass.m2 is from Jessica Sidman in 2002 ;
> 
> - M2/Macaulay2/tests/normal/CSM.test.m2 is from Paolo Aluffi 2002 ;
> 
> - M2/Macaulay2/tests/normal/ext2.m2 is from Ezra Miller ;
> 
> - M2/Macaulay2/tests/normal/ext3.m2 is from Hal Schenck ;
> 
> - M2/Macaulay2/tests/normal/groupcoh.m2 is from Sarah Wasserman ;
> 
> - M2/Macaulay2/tests/normal/monideal2.m2 is from Greg Smith ;
> 
> - M2/Macaulay2/tests/normal/primaryDecomposition.m2 is from Amelia
> Taylor ;
> 
> - M2/Macaulay2/tests/normal/schreyer.m2 is from Frank Schreyer ;
> 
> - M2/Macaulay2/tests/rationality/plausibility1.m2,
> M2/Macaulay2/tests/rationality/plausibility.m2,
> M2/Macaulay2/tests/rationality/proof-fixed.m2,
> M2/Macaulay2/tests/rationality/proof.m2,
> M2/Macaulay2/tests/rationality/ScorzaOcta-fixed.m2,
> M2/Macaulay2/tests/rationality/ScorzaOcta.m2 are from Christian
> Boehning & Hans-Christian Graf v. Bothmer ;
> 
> - M2/usr-build/pkg.m4 has a copyright notice :
> dnl Copyright © 2004 Scott James Remnant <scott@netsplit.com>.
> dnl Copyright © 2012-2015 Dan Nicholson <dbn.lists@gmail.com>
> followed by GPL-2+ ;
> 
> - M2/util/validator-runner.py needs a hunt for the copyright+license ;
> 
> 
> I'll review M2/Macaulay2/packages/ later... less `find . -type f`
> announces 2004 files to check!

It took a while to gather all the information, but I believe that 
debian/copyright should be in pretty good shape now.

Would you be able to take another look at the package?
https://salsa.debian.org/science-team/macaulay2

Thanks!
Doug