[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#936924: Moving libsvm to Debian Science team



On Wed, Dec 25, 2019 at 10:03:00AM +0100, Christian Kastner wrote:
> Andreas, what are you doing?
> 
> On 2019-12-25 07:52, Andreas Tille wrote:
> > On Tue, Dec 24, 2019 at 10:39:55AM -0500, Chen-Tse Tsai wrote:
> >> I just submitted a PR for dropping python2 dependencies:
> >> https://salsa.debian.org/science-team/libsvm/merge_requests/1
> >>
> >> Any comment is appreciated. I'll be working on upgrading to new upstream.
> > 
> > Looks very good!  I injected the patch by Helmut Grohne (#862234) as well.
> 
> 24 files changed, but debian/changelog only contains two entries.
> Nothing about changes to debhelper compat level, patches, etc. It would
> have been far more helpful to Chen-Tse (and thus to the team) to supply
> feedback on this.

  [ Andreas Tille ]
  * Secure URI in copyright format
  * Remove trailing whitespace in debian/changelog
  * Remove trailing whitespace in debian/control
  * Remove trailing whitespace in debian/copyright
  * Trim trailing whitespace.
  * Use secure URI in Homepage field.
  * Fix day-of-week for changelog entry 2.91-1.
  * Use Files-Excluded to exclude Windows binaries

Compat-level was changed before:

  e544cbc2 (Chen-Tse Tsai  2019-12-24 22:20:23 -0500  7)  debhelper-compat (= 12),

> Looking at Salsa, you also imported the new upstream version 3.24 an
> hour ago, something that Chen-Tse said just before that he would be
> working on? Is he wasting his time now?

I intended to help by recommending some automatic procedure
that fixes a lot of lintian issues.
 
> Furthermore, I indicated previously that after 3 years, we will almost
> certainly need a transition (upstream's versioning does not reflect
> SOVER. We arrived at liblinear4 from liblinear1 entirely from Debian
> builds discovering backwards-incompatible changes). Did you check this
> before updating to 3.24?
> 
> Can you please not rush things like this?

Sorry about this.  I should not have uploaded.

> This package has been sitting
> there for 3 years, a few Christmas Holiday days more or less will not
> make a difference. I (who happens to maintain another package by the
> same upstream) offered to help from the 27th; this could have waited
> until then and would have profited from doing so.

I agree and will not rush without coordination with this package. 

Kind regards

       Andreas.

-- 
http://fam-tille.de


Reply to: