[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#926330: RFS: cuba/4.2-1 [ITP]



Hi Francesco,

Le jeudi 11 avril 2019 à 23:21 +0200, Francesco Montanari a écrit :
> Thanks! I updated the package after going through Debian Science
> Policy and pushed the changes to the git repository. I'd appreciate if
> someone is available to sponsor the package.
> 
> As mentioned in the ITP [1], a previous version of the library,
> libcuba3, was already in Debian and I based the package on that one. I
> reached out to the previous maintainer to verify that he is fine with me
> reintroducing the package.

I quickly reviewed the package and I think it is almost ready. There
are however some issues:

— The autopkgtest does not work. I get:

autopkgtest [14:48:10]: test cuba: [-----------------------
make: *** No rule to make target 'check'.  Stop.
autopkgtest [14:48:11]: test cuba: -----------------------]
autopkgtest [14:48:11]: test cuba:  - - - - - - - - - - results - - - - - - - - - -
cuba                 FAIL non-zero exit status 2 

— I think there is a typo in the long description of libcuba4. It talks
about “libuba4-dev”, while I guess you meant “libcuba-dev”.

— In debian/changelog, you should keep the three former entries
corresponding to the previous version of the package. Keeping the whole
history of the package will facilitate the long-term maintenance.

See https://tracker.debian.org/media/packages/c/cuba/changelog-3.0%2B20111124-2


Best,

-- 
⢀⣴⠾⠻⢶⣦⠀  Sébastien Villemot
⣾⠁⢠⠒⠀⣿⡁  Debian Developer
⢿⡄⠘⠷⠚⠋⠀  http://sebastien.villemot.name
⠈⠳⣄⠀⠀⠀⠀  http://www.debian.org

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: