[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: It seems I have messed up mpi-default in team upload



On Thu, Apr 19, 2018 at 02:50:39PM +0200, Andreas Tille wrote:
> index 16e8518..6a59dc9 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,3 +1,13 @@
> +mpi-defaults (1.11) unstable; urgency=medium
> +
> +  * Team upload.
> +  * Remove "Adam C. Powell, IV" <hazelsct@debian.org> from uploaders since
> +    he is not active in Debian Science team since 5 years.
> +    Closes: #547460
> +  * Standards-Version: 4.1.4
> +
> + -- Andreas Tille <tille@debian.org>  Thu, 19 Apr 2018 13:31:37 +0200

You forgot a bit here, I pushed it for the next time.
I don't remember a policy in our team regarding "generate changelog
before upload" vs "edit changelog at each change", but I believe the
latter is more common here, so I guess it's my fault…

> Unfortunately this ends up in build failures on any architecture
> that tried to build:
> 
>    https://buildd.debian.org/status/package.php?p=mpi-defaults
> 
> The error is:
> 
> if [ "" = "openmpi" ]; then \
>   echo "mpi=openmpi-bin" > debian/mpi-default-bin.substvars; \
>   echo "mpi-dev=libopenmpi-dev" > debian/mpi-default-dev.substvars; \
> elif [ "" = "mpich" ]; then \
>   echo "mpi=mpich" > debian/mpi-default-bin.substvars; \
>   echo "mpi-dev=libmpich-dev" > debian/mpi-default-dev.substvars; \
> else \
>   echo "Unknown MPI implementation, stopping"; \
>   exit 1; \
> fi
> Unknown MPI implementation, stopping
> debian/rules:109: recipe for target 'override_dh_gencontrol' failed
> 
> Any idea what might went wrong here?


Apparently neither mpich nor openmpi are providing
/etc/alternatives/mpicc anymore, which broke mpi-defaults' assumptions.
Guess a quick fix would be to rely on some other link, like `mpi` or I
notice there is a `mpiCC` now (for openmpi, didn't look at mpich).

> Sorry for the mess - I assumed it would be a real trivial change

The change by itself is trivial and fine, but didn't you test build it
before uploading?... :)

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature


Reply to: