Re: Bug#777132: surf-alggeo: blends: not present on webpage
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hello Andreas, thanks for your review.
On 11/04/15 12:49, Andreas Tille wrote:
> On Sat, Apr 11, 2015 at 10:19:05AM +0200, Jerome BENOIT wrote:
>> Fixed,
>
> :-)
>
> I had a check of the packaging and think it is fine so far. However, I
> have a question about your way you are creating the source tarball. It
> seems the debian/repack script is basically removing files from the
> original download. Since some time this can be done via Files-Excluded
> in debian/copyright (see man uscan). I personally (well, I'm biased
> since I invented this method ;-)) consider this way more transparent
> than separate scripts and the result is more simple packaging. Do you
> have better reasons than "I was just not aware about this option" to
> not choose this way?
I was aware about this option.
I think this option is rather meant for clean upstream source:
here the upstream source tarball is polluted with .svn folders and a couple
of regular source files (C++ source + header) with an executable bit:
an ad hoc repack script seems then more appropriate.
>
> BTW, I consider d/changelog as way to long. For a new package simply
>
> * Initial release (Closes: #777132).
>
> is sufficient and the prefered form by ftpmaster. If you have no good
> reasons to mention all the details please remove them.
I like so much to show my effort. Whatever, I have just removed it.
>
> Kind regards
>
> Andreas.
>
Best wishes,
Jerome
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQEcBAEBAgAGBQJVKQfRAAoJEIC/w4IMSybjUjoH/1HrumCLLHrJUszNShCyfJA3
lqmfN6t5d3ZlhbEORUyGnEky8JmlF3esB5zNUjJBMg1YRWFCUNcvndtd0qo+6qdb
9XQCXAVKe5VUvqtAxVh9mcAytMWYsCHISxVLFtQ2UQv/0b1AUv6JTHmQ3h3br0km
FFiKt5XEWNR2BuGaPzEkJBkGFhSEfjYFLEpdSlUw5+IvxdXza5aP/Sh4RXbIbzra
fQBoZ3KFvrJE6F2cBeD5rq4Kx8bBXc9YABa0Mriwc60eL2wy+D9q1LCIrCrQNkEj
SyR/pibHtHRkARwTqUnwJQYvEM9c7r8u5IRtOHHWy9in1SU+nXrlzFGNDQq82nA=
=AxQ2
-----END PGP SIGNATURE-----
Reply to: