[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

RE:h5py/2.2.1-2~exp1




Le 29 mars 2015 08:43, "PICCA Frederic-Emmanuel" <frederic-emmanuel.picca@synchrotron-soleil.fr> a écrit :
>
> Hello Gishlain
>
> In your rules file we can see this.
>
> >ifneq ($(wildcard /usr/lib/$(DEB_HOST_MULTIARCH)/hdf5/serial/libhdf5.so),)
> >  export CPPFLAGS=-I/usr/include/hdf5/serial
> >  export LDFLAGS=-Wl,-L/usr/lib/$(DEB_HOST_MULTIARCH)/hdf5/serial
> >endif
>
> It seems to me fragile.
>
> what about relying on pkgconfig to provide the right flags
>
> export CFLAGS=$(shell pkg-config --cflags hdf5)
> export LDFLAGS=$(shell pkg-config --libs hdf5)
>
>
> for the clean par , I propose this sort of target.
>
>         # remove the .c cython generated files
>         find h5py -iname *.pyx | sed -e 's,\.pyx,\.c,g' | xargs -r rm -f
>
> cheers
>
>
> Frederic

Thanks for you suggestion for the clean rule. That's what I had in mind too.

For the compile and link flags, i believe they come from the latest nmu. Your solution is more solid indeed.

Cheers,
Ghis


Reply to: