Re: octomap_1.6.6-1_amd64.changes REJECTED
- To: Leopold Palomo-Avellaneda <leo@alaxarxa.net>
- Cc: Debian Science List <debian-science@lists.debian.org>
- Subject: Re: octomap_1.6.6-1_amd64.changes REJECTED
- From: Andreas Tille <andreas@an3as.eu>
- Date: Tue, 29 Jul 2014 14:00:40 +0200
- Message-id: <[🔎] 20140729120040.GP19390@an3as.eu>
- In-reply-to: <201407281752.29178.leo@alaxarxa.net>
- References: <E1X5aQn-0006Ks-Bb@franck.debian.org> <201407141413.42536.leo@alaxarxa.net> <20140715083251.GI12063@an3as.eu> <201407281752.29178.leo@alaxarxa.net>
HI Leopold,
On Mon, Jul 28, 2014 at 05:52:24PM +0200, Leopold Palomo-Avellaneda wrote:
> >
> > If everything is DFSG free usually repackaging is not considered best
> > practice. It depends whether you are pretty sure that the Debian
> > packaged version is used and what size the unneeded stuff might occupy.
> > Given that it makes about 20% of the uncompressed code it might be
> > worth considering.
>
> $du -s *
> 3848 octomap-1.6.6
> 2544 octomap-1.6.6_without
>
> we are talking about this numbers. It's ~66% it's ok.
+1
> > You can approach this easily by adding
> >
> > Files-Excluded: octovis/src/extern/QGLViewer
> >
> > to debian/control and than use in debian/rules:
> >
> > get-orig-source:
> > uscan --verbose --force-download --repack --compress xz
> >
> > If you do so please also add
> >
> > opts=uversionmangle=s/$/+dfsg/
> >
> > to debian/watch. But I leave the final decision to you - just
> > mentioning what would be the most simple way to approach it.
>
>
> I have an error here. I have put the line in control file, under the sources
> part and in watch file I have:
>
> # For GitHub projects you can use the tags page:
> opts=uversionmangle=s/$/+dfsg/,filenamemangle=s/.+\/v?
> (\d\S*)\.tar\.gz/octomap-$1\.tar\.gz \
> https://github.com/OctoMap/octomap/tags .*/v?(\d\S*)\.tar\.gz
>
>
> but I got:
>
> fakeroot debian/rules get-orig-source
> uscan --verbose --force-download --repack --compress xz
> -- Scanning for watchfiles in .
> -- Found watchfile in ./debian
> -- In debian/watch, processing watchfile line:
> opts=uversionmangle=s/$/+dfsg/,filenamemangle=s/.+\/v?
> (\d\S*)\.tar\.gz/octomap-$1\.tar\.gz https://github.com/OctoMap/octomap/tags
> .*/v?(\d\S*)\.tar\.gz
> -- Found the following matching hrefs:
> /OctoMap/octomap/archive/v1.6.6.tar.gz (1.6.6+dfsg)
> /OctoMap/octomap/archive/v1.6.5.tar.gz (1.6.5+dfsg)
> /OctoMap/octomap/archive/v1.6.4.tar.gz (1.6.4+dfsg)
> /OctoMap/octomap/archive/v1.5.7.tar.gz (1.5.7+dfsg)
> /OctoMap/octomap/archive/v1.6.3.tar.gz (1.6.3+dfsg)
> /OctoMap/octomap/archive/v1.6.2.tar.gz (1.6.2+dfsg)
> /OctoMap/octomap/archive/v1.6.1.tar.gz (1.6.1+dfsg)
> /OctoMap/octomap/archive/v1.5.6.tar.gz (1.5.6+dfsg)
> /OctoMap/octomap/archive/v1.5.5.tar.gz (1.5.5+dfsg)
> /OctoMap/octomap/archive/v1.6.0.tar.gz (1.6.0+dfsg)
> /OctoMap/octomap/archive/v1.5.4.tar.gz (1.5.4+dfsg)
> /OctoMap/octomap/archive/v1.5.3.tar.gz (1.5.3+dfsg)
> /OctoMap/octomap/archive/v1.5.2.tar.gz (1.5.2+dfsg)
> /OctoMap/octomap/archive/v1.5.1.tar.gz (1.5.1+dfsg)
> /OctoMap/octomap/archive/v1.4.3.tar.gz (1.4.3+dfsg)
> /OctoMap/octomap/archive/v1.5.0.tar.gz (1.5.0+dfsg)
> /OctoMap/octomap/archive/v1.4.2.tar.gz (1.4.2+dfsg)
> /OctoMap/octomap/archive/v1.4.1.tar.gz (1.4.1+dfsg)
> /OctoMap/octomap/archive/v1.4.0.tar.gz (1.4.0+dfsg)
> /OctoMap/octomap/archive/v1.3.2.tar.gz (1.3.2+dfsg)
> /OctoMap/octomap/archive/v1.2.1.tar.gz (1.2.1+dfsg)
> /OctoMap/octomap/archive/v1.2.tar.gz (1.2+dfsg)
> /OctoMap/octomap/archive/v1.1.tar.gz (1.1+dfsg)
> /OctoMap/octomap/archive/v1.0.tar.gz (1.0+dfsg)
> /OctoMap/octomap/archive/v0.91.tar.gz (0.91+dfsg)
> /OctoMap/octomap/archive/v0.9.tar.gz (0.9+dfsg)
> /OctoMap/octomap/archive/v0.8.tar.gz (0.8+dfsg)
> /OctoMap/octomap/archive/v0.6.tar.gz (0.6+dfsg)
> /OctoMap/octomap/archive/v0.42.tar.gz (0.42+dfsg)
> /OctoMap/octomap/archive/v0.4.tar.gz (0.4+dfsg)
> /OctoMap/octomap/archive/v0.26.tar.gz (0.26+dfsg)
> /OctoMap/octomap/archive/v0.24.tar.gz (0.24+dfsg)
> /OctoMap/octomap/archive/v0.22.tar.gz (0.22+dfsg)
> /OctoMap/octomap/archive/v0.16.tar.gz (0.16+dfsg)
> /OctoMap/octomap/archive/v0.14.tar.gz (0.14+dfsg)
> /OctoMap/octomap/archive/v0.1.tar.gz (0.1+dfsg)
> uscan: In debian/watch, potentially unsafe or malformed filenamemangle
> pattern:
> 's/.+\/v?(\d\S*)\.tar\.gz/octomap-$1\.tar\.gz' found. Skipping watchline
> https://github.com/OctoMap/octomap/tags .*/v?(\d\S*)\.tar\.gz
> -- Scan finished
> make: *** [get-orig-source] Error 1
Can you please commit your changes to let me reproduce?
> What I'm doing wrong?
I'll check and try to fix your commit to Git.
Kind regards
Andreas.
--
http://fam-tille.de
Reply to: