[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#728360: RFS: open-axiom/1.5.0~svn3056-1

Hi Igor,

This is not a full review, but just few quick notes.

>   I am looking for a sponsor for my package "open-axiom"

Have you thought about maintaining this package under umbrella of Debian
Science Team [1][2]? Package looks completely suitable for it.

I am not aware if this was already discussed earlier. If yes, please give me a
link to that thread. If not, consider this mail as an official invitation. =)

[1] https://wiki.debian.org/DebianScience
[2] http://debian-science.alioth.debian.org/debian-science-policy.html

>   Changes since the last upload:
>   * New upstream version.
>   * Use xz compression for both source tarball and packages
>   * Require g++ >= 4.7 for C++11
>   * Refreshed patches
>   * touch aclocal.m4 -r configure.ac to avoid rebuilding aclocal.m4 which
>     requires aclocal 1.13
>   * Do not patch configure.ac, but override variables in Makefiles (due to
>     automake 1.13 too)
>   * Require SBCL
>   * Enable hardening (include /usr/share/dpkg/buildflags.mk for build flags)
>   * Use dh-buildinfo
>   * Override hardening-no-relro on usr/lib/open-axiom/bin/AXIOMsys
>   * Build depends on autotools-dev to update config.*
>   * Bump standards version 3.9.3 → 3.9.4, no changes

Personally I prefer to look at commits in git repo. But git repo [3] of this
package is outdated. Please push your recent changes there.

Also it would be nice if you added git tags for package versions which were
uploaded to Debian archive earlier. Usually they looks like "debian/${VER}".
Signed tags are welcome.

[3] http://anonscm.debian.org/gitweb/?p=pkg-open-axiom/pkg-open-axiom.git

Please add few screenshots with examples of using open-axiom to [4]. Even
screenshots of console applications are useful.

[4] http://screenshots.debian.net/

You have never used tarballs with stable releases for this package, so your
current debian/watch file is useless. Please update it for checking svn
revision. You may find examples at [5] or at [6].

[5] https://wiki.debian.org/debian/watch/
[6] http://anonscm.debian.org/gitweb/?p=debian-science/packages/elmerfem.git;a=blob;f=debian/watch;hb=HEAD

Your get-orig-source in debian/rules violates Debian Policy §4.9:
"This target may be invoked in any directory..."

Just replace:
SRC_VERSION  := $(shell dpkg-parsechangelog | awk '/^Version:/ {sub(/-[^-]*/, "", $$2); print $$2}')
by something like this:
DEBIAN_PATH  := $(abspath $(dir $(firstword $(MAKEFILE_LIST))))
SRC_VERSION  := $(shell dpkg-parsechangelog -l$(DEBIAN_PATH)/changelog | awk '/^Version:/ {sub(/-[^-]*/, "", $$2); print $$2}')

String "README*" in debian/open-axiom.docs is quite useless. Did you have
"debian/README*" in mind or anything else?

Please use lintian with `-ivIE --pedantic` options for checking packages.

These lintian tags may be easily fixed:
I: open-axiom source: vcs-field-not-canonical http://git.debian.org/git/pkg-open-axiom/pkg-open-axiom.git http://anonscm.debian.org/git/pkg-open-axiom/pkg-open-axiom.git
I: open-axiom source: vcs-field-not-canonical http://git.debian.org/?p=pkg-open-axiom/pkg-open-axiom.git http://anonscm.debian.org/gitweb/?p=pkg-open-axiom/pkg-open-axiom.git
I: open-axiom: desktop-entry-lacks-keywords-entry usr/share/applications/open-axiom.desktop

Please use [DEP-3] to fix these lintian notes:
I: open-axiom source: quilt-patch-missing-description no-missing-messages.patch
I: open-axiom source: quilt-patch-missing-description non-static-open-axiom-binary.patch

[DEP-3] http://dep.debian.net/deps/dep3/

You may want to fix as well:
I: open-axiom: hardening-no-fortify-functions usr/lib/open-axiom/bin/AXIOMsys
But this is optional.

Please update your debian/copyright file in according to Copyright format 1.0:
You have already made a preliminary work, so just finish it.
Also some copyright holders are not listed in this file now.
This file is very important and should be always in actual state.

I have not looked into source code and debdiff between versions yet.
More remarks are possible.

Best regards,

Reply to: