Re: Bug#692000: ITP: liblbfgs -- L-BFGS solver for dense nonlinear optimization problems
On Sun, Nov 11, 2012 at 01:29:17PM -0800, Dima Kogan wrote:
> > dpkg-source: error: can't build with source format '3.0 (quilt)': no upstream tarball found at ../libdogleg_0.08.orig.tar.{bz2,gz,lzma,xz}
> >
> > Any reason to not use pristine-tar?
>
> I can use pristine-tar here, but I'm not completely clear on why it is useful.
> The upstream source comes from a tag in a git repo. This tag fully describes the
> sources. One could make a tarball from this tag (this is what pristine-tar would
> do), but why would this be a useful thing to do? Tell me if having a
> pristine-tar branch is desirable, and I'll set it up.
Pristine-tar ensures a tarball with identical MD5 sum which is pretty
important if different people try to upload different package versions
of the same upstream version. In case somebody else than me who did the
initial upload with MD5sum abc tries to create a Debian package '*-2'
and does not download the tarball via dpkg-source he will end up with a
different upstream tarball (not byte different when unpackaging but with
different md5sum). This will result in a rejection from ftpmaster.
> I belive you see the dpkg-source error not because of the missing pristine-tar
> but because you didn't ask for an upstream tarball to be generated. You likely
> did a 'git checkout' and then a 'dpkg-buildpackage', right?
No.
> If you do
> 'git-buildpackage' instead, it should build the source tarball from the tag
> before building the binary package. Please tell me if I'm not understanding
> something.
I used git-buildpackage in both cases - one created the tarball and one
did not - absolutely no idea why.
> Thanks, Andreas. One note is that I don't think the lintian warnings are
> entirely false-positives. The liblbfgs Makefiles don't accept external LDFLAGS,
> so the linker hardening pieces were likely ignored (-Wl,-z,relro for instance).
> This is probably not a huge deal, though.
Finally we can work out this in a later upload.
> Also, git-buildpackage can create a tag in the repo to identify particular
> package releases. One can make it with 'git-buildpackage --git-tag'. I'll do
> this now for liblbfgs.
I know this however, in the case of an initial upload I tend to do the
tagging manually once the package was really accepted.
Kind regards
Andreas.
--
http://fam-tille.de
Reply to: