[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#681314: unblock: yp-svipc/0.14-2



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock source package yp-svipc.

It builds the following binary packages:
 - python-svipc
 - python3-svipc
 - yorick-svipc

I attach a debdiff and explain the changes below.

1- Hardening flags release goal:
   http://bugs.debian.org/680216
Fixed for python*-svipc by putting CPPFLAGS in CFLAGS, for yorick-svipc by
passing Y_LDFLAGS etc. to make.

2- 0.14-1 failed to build on kfreebsd-any:
   http://bugs.debian.org/679919
Portability code for *BSD and Darwin is erroneously activated on GNU/kFreeBSD,
which doesn't need it.
Fixed for python*-svipc by patching setup.py; for yorick-svipc by passing
PKG_CFLAGS explicitly to make.

3- the yorick-full meta-package (src:yorick), already unblocked, is waiting for
yorick-svipc to build on kfreebsd-* before it can migrate.
   http://release.debian.org/migration/testing.pl?package=yorick
Fixing the above-mentioned FTBFS takes us halfway through to letting yorick
migrate (Yorick is also waiting for yorick-gyoto, I'm working on it).

Kind regards, Thibaut.

unblock yp-svipc/0.14-2

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-2-686-pae (SMP w/2 CPU cores)
diff -Nru yp-svipc-0.14/debian/changelog yp-svipc-0.14/debian/changelog
--- yp-svipc-0.14/debian/changelog	2012-06-22 11:25:24.000000000 +0200
+++ yp-svipc-0.14/debian/changelog	2012-07-11 13:41:39.000000000 +0200
@@ -1,3 +1,14 @@
+yp-svipc (0.14-2) unstable; urgency=low
+
+  * Bug fix: "don't rely on yorick to pass the fortified build flags"
+    (Closes: #680216).
+  * Bug fix: "FTBFS on kfreebsd-i386 and kfreebsd-amd64: "conflicting
+    types for semtimedop"" (Closes: #679919). Involves a patch for the
+    Python modules (fix_679919_kFreeBSD_FTBFS) and passing PKG_CFLAGS when
+    building the Yorick plug-in.
+
+ -- Thibaut Paumard <paumard@users.sourceforge.net>  Wed, 11 Jul 2012 13:41:39 +0200
+
 yp-svipc (0.14-1) unstable; urgency=low
 
   * Initial release (Closes: #668841)
diff -Nru yp-svipc-0.14/debian/patches/fix_679919_kFreeBSD_FTBFS yp-svipc-0.14/debian/patches/fix_679919_kFreeBSD_FTBFS
--- yp-svipc-0.14/debian/patches/fix_679919_kFreeBSD_FTBFS	1970-01-01 01:00:00.000000000 +0100
+++ yp-svipc-0.14/debian/patches/fix_679919_kFreeBSD_FTBFS	2012-07-11 13:58:53.000000000 +0200
@@ -0,0 +1,24 @@
+Description: fix 679919 FTBFS on kfreebsd-*
+ upstream provides an implementation of semtimedop which they use on FreeBSD
+ and MacOS. It is eroneously used also under GNU/kFreeBSD and GNU/Hurd.
+ This patch disables it altogether for the python modules. 
+Author: Thibaut Paumard <paumard@users.sourceforge.net>
+Origin: vendor
+Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=679919
+Forwarded: no
+Last-Update: 2012-07-11
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/setup.py
++++ b/setup.py
+@@ -32,10 +32,8 @@
+    ('SVIPC_NOSEGFUNC',               None),
+    ]
+ 
+ platform=uname()[0]
+-if platform != 'Linux':
+-   define_macros.append(('SVIPC_HACKS', None))
+ 
+ extra_compile_args=[
+    #'-g3',
+    #'-ggdb3'
diff -Nru yp-svipc-0.14/debian/patches/series yp-svipc-0.14/debian/patches/series
--- yp-svipc-0.14/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ yp-svipc-0.14/debian/patches/series	2012-07-11 14:08:11.000000000 +0200
@@ -0,0 +1 @@
+fix_679919_kFreeBSD_FTBFS
diff -Nru yp-svipc-0.14/debian/rules yp-svipc-0.14/debian/rules
--- yp-svipc-0.14/debian/rules	2012-06-22 11:25:06.000000000 +0200
+++ yp-svipc-0.14/debian/rules	2012-07-11 14:17:49.000000000 +0200
@@ -6,6 +6,7 @@
 # This has to be exported to make some magic below work.
 export DH_OPTIONS
 
+CFLAGS += $(CPPFLAGS)
 
 %:
 	dh $@ --with python2 \
@@ -23,7 +24,10 @@
 	set -ex; for python in $(shell py3versions -r); do \
 	  $$python setup.py build; \
 	done;
-	cd yorick; make
+	cd yorick; make COPT_DEFAULT="" \
+	                Y_CFLAGS="$(CFLAGS)" \
+	                Y_LDFLAGS="$(LDFLAGS)" \
+	                PKG_CFLAGS="-I ../common"
 
 override_dh_auto_install:
 	dh_auto_install

Reply to: