[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1024882: marked as done (scm: FTBFS on armel, armhf and mipsel)

Your message dated Mon, 19 Dec 2022 22:15:57 +0000
with message-id <E1p7OQP-000cyZ-Li@fasolo.debian.org>
and subject line Bug#1024882: fixed in scm 5f3-2
has caused the Debian Bug report #1024882,
regarding scm: FTBFS on armel, armhf and mipsel
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1024882: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1024882
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: scm
Version: 5f3-1+b1
Severity: serious
Tags: ftbfs, patch
Justification: fails to build from source (but built successfully in the past)

There is a build failure affecting scm on armel, armhf and mipsel:

| ;ERROR: "r4rstest.scm": integer-length: Wrong type in arg1 (0 . 0)
| ; in expression: (#@string->number (#@number->string #@number))
| ; in scope:
| ;   (number)  procedure testit
| ;   (testit . #@define)
| ;   (x)  procedure float-print-test
| ;   (log2 slow-frexp float-precision float-print-test mult-float-print-test float-rw-range-test float-powers-of-2-test . #@define)
| ;   (f0.0 f0.5 f1.0 f2.0 . #@let)
| ;   ()  procedure test-inexact-printing
| ; defined by load: "r4rstest.scm"
| 
| ;STACK TRACE
| 1; ((#@eqv? #@number (#@string->number (#@number->string #@number ...
| 2; (#@let* ((xx (#@+ #@x (#@* #@j #@eps))) (ok? (#@testit #@xx))) ...
| 3; (#@do ((j -100 (#@+ #@j 1))) ((#@or (#@not #@all-ok?) (#@> #@j ...
| 4; (#@define ((log2 (#@let ((l2 (#@log 2)))  (#@lambda (x) (/ (lo ...
| 5; (#@let ((have-inexacts? (#@and (#@string->number "0.0") (#@ine ...
| ...
| 
| ; program args: ("./scm" "-fr4rstest.scm" "-e(test-sc4)(test-cont)(test-delay)(gc)" "-e" "(or (null? errs) (quit 1))")
| make[1]: *** [Makefile:559: check] Error 1

<https://buildd.debian.org/status/fetch.php?pkg=scm&arch=armhf&ver=5f3-1&stamp=1651073592&raw=0>

I've tried to debug it and it's some sort of Heisenbug. The bug is
triggered by the buildds because they run with stdout redirected to a
file and stdin redirected from /dev/null. I think that this changes
the allocation patterns of the program slightly and exposes the bug.

There is a recent change in scm that adds the bigrec() function for
recycling bignums, i.e. freeing them without waiting for the gc to do
it. I believe that some use of this function is the source of the bug.
Note that the assertion error says "Wrong type in arg1 (0 . 0)", which
is the object after bigrecy() has modified it. I tried changing
"CAR(bgnm) = INUM0;" to "CAR(bgnm) = MAKINUM(42);" and the error then
changed to "Wrong type in arg1 (42 . 0)", which suggests that
bigrecy() was run on a reachable bignum.

I haven't managed to figure out exactly which call to bigrecy() is
causing the problem, so here's a patch to just disable it altogether.
The bigrecy() function is a performance hack, so disabling it
shouldn't cause any problems.


diff --git a/scl.c b/scl.c
index a572557..8d8026c 100644
--- a/scl.c
+++ b/scl.c
@@ -133,12 +133,14 @@ void strrecy(str)
 void bigrecy(bgnm)
      SCM bgnm;
 {
+#if 0
   if (IMP(bgnm) || !BIGP(bgnm)) return;
   DEFER_INTS;
   must_free(CHARS(bgnm), (sizet)NUMDIGS(bgnm)*sizeof(BIGDIG));
   CAR(bgnm) = INUM0;
   CDR(bgnm) = INUM0;
   ALLOW_INTS;
+#endif
 }
 
 /* can convert to string accurately with bignums */

--- End Message ---
--- Begin Message --- 
Source: scm
Source-Version: 5f3-2
Done: Göran Weinholt <weinholt@debian.org>

We believe that the bug you reported is fixed in the latest version of
scm, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1024882@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Göran Weinholt <weinholt@debian.org> (supplier of updated scm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 18 Dec 2022 14:15:57 +0100
Source: scm
Architecture: source
Version: 5f3-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Scheme Dream Team <debian-scheme@lists.debian.org>
Changed-By: Göran Weinholt <weinholt@debian.org>
Closes: 1024882
Changes:
 scm (5f3-2) unstable; urgency=medium
 .
   Team upload.
 .
   [ Göran Weinholt ]
   * use-compiler-flags.patch: Pass through compilation flags to gcc
   * debian/patches/disable-bigrecy.patch: Disable bigrecy() again
     (Closes: #1024882)
   * debian/rules: Disable C optimizations to work around a test failure
   * debian/control: Add myself to uploaders
 .
   [ Debian Janitor ]
   * Remove constraints unnecessary since buster
   * Update standards version to 4.6.1, no changes needed.
Checksums-Sha1:
 e21f14d7b0c51c8c8722b641fa118892c99781f6 2051 scm_5f3-2.dsc
 e14a4af52b8cacfdced46fa9ddaa86cdef63c7cd 14520 scm_5f3-2.debian.tar.xz
 42d674cc29b796cd65840872c8dfb686d55132c5 7596 scm_5f3-2_source.buildinfo
Checksums-Sha256:
 08c1c4ffd2a92a2722ac081ec84ad402cf38c92ba4308d4e6d89d8777b238894 2051 scm_5f3-2.dsc
 24e9c0a98b2254b791fdd749d9a91dad9c8653798fbb830912323fa754cc563e 14520 scm_5f3-2.debian.tar.xz
 9ed534e28c3b52ce4dc4f3315d5d69619513c51bdc57ff36c59f31918ad3a6df 7596 scm_5f3-2_source.buildinfo
Files:
 854a9d70928da9e31a715e815afd18d0 2051 interpreters optional scm_5f3-2.dsc
 5ebccf04ff2675db0a6ebde7583eaf6a 14520 interpreters optional scm_5f3-2.debian.tar.xz
 1a6added3bc43b7cf021941ba14ba5e2 7596 interpreters optional scm_5f3-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEq+9SWYIFojDzWUBw933wfyFewnMFAmOfE30ACgkQ933wfyFe
wnMHpg//YBJ5sUY8gB5eOxiZJU+RJKqRCESbL8yLa2Jhz5pnb05JSYCfFBSx4RtG
dr9f19dWGfSzY5/1s8gILPrv/EpUK68AAuEsE8RwuDnBltgrnXrB4ClnJ8cd//Xw
Ynp36vNwHPc2WswQgCqukNQ9rSB0Qc0SJW7+vH63eticVtDVRzU+qhRBX1t7TbYn
8BJJdLKumuLVxhExhp5BFSeLVc5Rx3thoH3J7ZkfAzn24W6tjg3rpskq0MMkIVU4
rdnQwl2RhrBKxcEJKyjZCBP9jlKMK7eoVfDosOW+tuiLRkwe7eMBDkYwo2/Zb0+V
2JLyXpNl3cy1YIRJPMniqYNLlI8SKhd6aYOg9bl+XsiW7S25vo/u5HqTnbV/naVi
ulL7GA8kZAv4HmQUkTzI6ffsJ4V+0BYKPVZ951xzbTr9owJsyxscp5sc+bwl5QNG
0n6YeD631VrtXpXmwIFLK/cGK/MHWdUpuwsIaE2kdbos9fs6ViL5rxEO7V1Fx6Xo
3vHVvWOE2IxCuK5Abq377gwoDOPHkf05WdZHO4V8wsjNweZuQgVK015qjOn2b5kI
N14BauicaWWFo+IqinSikHLnm6z9jK2KV8UY2+CQK2nVp9DXXL7wsNHBxDGILsLH
5ZjAqZoXxIl+eqfHbAIG4EPMh8xLZM2f4PQK3XRXUHd8VAgcJ7A=
=F/xt
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: