Re: [syzbot] [hfs?] WARNING in hfs_write_inode
- To: Dave Chinner <david@fromorbit.com>
- Cc: Jeff Layton <jlayton@kernel.org>, Matthew Wilcox <willy@infradead.org>, John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>, Dmitry Vyukov <dvyukov@google.com>, Viacheslav Dubeyko <slava@dubeyko.com>, Arnd Bergmann <arnd@arndb.de>, Linus Torvalds <torvalds@linux-foundation.org>, syzbot <syzbot+7bb7cd3595533513a9e7@syzkaller.appspotmail.com>, Andrew Morton <akpm@linux-foundation.org>, christian.brauner@ubuntu.com, Damien Le Moal <damien.lemoal@opensource.wdc.com>, Linux FS Devel <linux-fsdevel@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, syzkaller-bugs@googlegroups.com, ZhangPeng <zhangpeng362@huawei.com>, linux-m68k@lists.linux-m68k.org, debian-ports <debian-ports@lists.debian.org>
- Subject: Re: [syzbot] [hfs?] WARNING in hfs_write_inode
- From: Finn Thain <fthain@linux-m68k.org>
- Date: Fri, 21 Jul 2023 11:03:28 +1000 (AEST)
- Message-id: <[🔎] 60b57ae9-ff49-de1d-d40d-172c9e6d43d5@linux-m68k.org>
- In-reply-to: <[🔎] ZLmzSEV6Wk+oRVoL@dread.disaster.area>
- References: <ab7a9477-ddc7-430f-b4ee-c67251e879b0@app.fastmail.com> <2575F983-D170-4B79-A6BA-912D4ED2CC73@dubeyko.com> <46F233BB-E587-4F2B-AA62-898EB46C9DCE@dubeyko.com> <Y7bw7X1Y5KtmPF5s@casper.infradead.org> <50D6A66B-D994-48F4-9EBA-360E57A37BBE@dubeyko.com> <CACT4Y+aJb4u+KPAF7629YDb2tB2geZrQm5sFR3M+r2P1rgicwQ@mail.gmail.com> <ZLlvII/jMPTT32ef@casper.infradead.org> <[🔎] 2d0bd58fb757e7771d13f82050a546ec5f7be8de.camel@physik.fu-berlin.de> <[🔎] ZLl2Fq35Ya0cNbIm@casper.infradead.org> <[🔎] 868611d7f222a19127783cc8d5f2af2e42ee24e4.camel@kernel.org> <[🔎] ZLmzSEV6Wk+oRVoL@dread.disaster.area>
On Fri, 21 Jul 2023, Dave Chinner wrote:
> > I suspect that this is one of those catch-22 situations: distros are
> > going to enable every feature under the sun. That doesn't mean that
> > anyone is actually _using_ them these days.
I think the value of filesystem code is not just a question of how often
it gets executed -- it's also about retaining access to the data collected
in archives, museums, galleries etc. that is inevitably held in old
formats.
>
> We need to much more proactive about dropping support for unmaintained
> filesystems that nobody is ever fixing despite the constant stream of
> corruption- and deadlock- related bugs reported against them.
>
IMO, a stream of bug reports is not a reason to remove code (it's a reason
to revert some commits).
Anyway, that stream of bugs presumably flows from the unstable kernel API,
which is inherently high-maintenance. It seems that a stable API could be
more appropriate for any filesystem for which the on-disk format is fixed
(by old media, by unmaintained FLOSS implementations or abandoned
proprietary implementations).
Being in userspace, I suppose FUSE could be a stable API though I imagine
it's not ideal in the sense that migrating kernel code there would be
difficult. Maybe userspace NFS 4 would be a better fit? (I've no idea, I'm
out of my depth in /fs...)
Ideally, kernel-to-userspace code migration would be done with automatic
program transformation -- otherwise it would become another stream of
bugs.
Reply to: