[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#807442: patch



On Mon, Dec 14, 2015 at 11:31:26AM +0100, Hendrik Brueckner wrote:
> On Mon, Dec 14, 2015 at 09:28:08AM +0100, Hendrik Brueckner wrote:
> > On Sun, Dec 13, 2015 at 03:50:01PM +0100, Philipp Kern wrote:
> > > On Tue, Dec 08, 2015 at 03:17:49PM -0700, dann frazier wrote:
> > > > --- s390-tools-1.32.0/debian/s390-tools.install	2014-07-26 23:59:18.000000000 +0200
> > > > +++ s390-tools-1.32.0/debian/s390-tools.install	2015-12-08 23:08:30.000000000 +0100
> > > > @@ -10,6 +10,10 @@
> > > >  /sbin/dasdview
> > > >  /usr/share/man/man8/dasdview.8
> > > >  
> > > > +# dbginfo.sh
> > > > +/sbin/dbginfo.sh
> > > > +/usr/share/man/man1/dbginfo.sh.1
> > > > +
> > >
> > >  * Unless this is expected to be in /sbin, given that it's user
> > >    invoked and not usually scripted, should this be in /usr/sbin
> > >    instead?
> 
> I am not sure what you exactly mean with "user" invoked.

I believe that note means that this utility appears to be something
that a user would execute in an interactive terminal vs. e.g. a script
in early boot.

> Anyhow, /sbin/ makes sense because the intention of the dbginfo.sh
> script is to collect system and debugging information.  So it is
> important to have it available early (even before /usr becomes
> mounted).

While this maybe a theoretical use case, I don't think the script has
been designed to run in this environment. As one example, it
calls "/usr/bin/id" to check if it is running as root. It also uses the
"find" command in a number of places which, at least on Debian
systems, is installed in /usr/bin.

> I would also go further and would suggest to included it in the
> s390-tools udeb package to be available in the debian installer
> too.  But I would have to check if it runs in the debian installer
> environment.  I could also imagine to integrate it into the
> installation-report module.

I'd suggest opening separate bugs for those.


Reply to: