[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#599931: marked as done (zipl hook scripts invoke zipl multiple times)

Your message dated Wed, 26 Oct 2011 15:17:45 +0000
with message-id <E1RJ5Ef-0005yv-CG@franck.debian.org>
and subject line Bug#599931: fixed in s390-tools 1.14.0-1
has caused the Debian Bug report #599931,
regarding zipl hook scripts invoke zipl multiple times
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
599931: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=599931
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: s390-tools
Version: 1.8.3-2
Severity: wishlist

The zipl hook scripts, /etc/kernel/postinst.d/zz-zipl and
/etc/kernel/postrm.d/zz-zipl, invoke zipl multiple times.  It would be good
to incorporate logic similar to that included in the initramfs-tools hook
script so that zipl only gets invoked once.  For example, at the
time of this writing, /etc/kernel/postinst.d/zz-zipl looks something like this:

-----

   #!/bin/sh
   exec zipl </dev/null >&2

-----

This script is called both for pre-configuration and for configuration,
causing zipl to be invoked twice.  Consider instead the following logic:

-----

   #!/bin/sh
   set -e

   # Avoid executing multiple times.
   if [ -n "$DEB_MAINT_PARAMS" ];then
       eval set -- "$DEB_MAINT_PARAMS"
       if [ -z "$1" ] || [ "$1" != "configure" ];then
           exit 0
       fi
   fi

   
   if [ -f /etc/zipl.conf ];then
      zipl >&2
   else
      echo "WARNING, not invoking zipl: /etc/zipl.conf not found" >&2
   fi

-----

This script exits without invoking zipl when invoked during pre-configuration,
but does invoke zipl during configuration.  (It also does not invoke zipl
if zipl's configuration file is not found.)  Similarly,
/etc/kernel/postrm.d/zz-zipl currently looks something like this:

-----

#!/bin/sh
exec zipl </dev/null >&2

-----

This script is invoked for a remove and also for a purge.  When a purge is done,
the script is called twice: first for the remove process, then a second time
for the purge process.  Thus, zipl gets executed twice.  Consider instead
the following logic:

-----

   #!/bin/sh

   # Avoid executing multiple times.
   if [ -n "$DEB_MAINT_PARAMS" ];then
       eval set -- "$DEB_MAINT_PARAMS"
       if [ -z "$1" ] || [ "$1" != "remove" ];then
           exit 0
       fi
   fi

   if [ -f /etc/zipl.conf ];then
      zipl >&2
   else
      echo "WARNING, not invoking zipl: /etc/zipl.conf not found" >&2
   fi
   exit 0

-----

This logic causes the script to exit without invoking zipl
when called for purge processing, but allows zipl to be invoked
during remove processing.  (It also forces a clean exit in case
of an error from zipl, which is desirable during a remove.)

-- 
  .''`.     Stephen Powell    
 : :'  :
 `. `'`
   `-

--- End Message ---
--- Begin Message --- 
Source: s390-tools
Source-Version: 1.14.0-1

We believe that the bug you reported is fixed in the latest version of
s390-tools, which is due to be installed in the Debian FTP archive:

s390-tools-udeb_1.14.0-1_s390.udeb
  to main/s/s390-tools/s390-tools-udeb_1.14.0-1_s390.udeb
s390-tools_1.14.0-1.debian.tar.gz
  to main/s/s390-tools/s390-tools_1.14.0-1.debian.tar.gz
s390-tools_1.14.0-1.dsc
  to main/s/s390-tools/s390-tools_1.14.0-1.dsc
s390-tools_1.14.0-1_s390.deb
  to main/s/s390-tools/s390-tools_1.14.0-1_s390.deb
s390-tools_1.14.0.orig.tar.bz2
  to main/s/s390-tools/s390-tools_1.14.0.orig.tar.bz2



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 599931@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Philipp Kern <pkern@debian.org> (supplier of updated s390-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 26 Oct 2011 16:11:35 +0200
Source: s390-tools
Binary: s390-tools s390-tools-udeb
Architecture: source s390
Version: 1.14.0-1
Distribution: unstable
Urgency: low
Maintainer: Debian S/390 Team <debian-s390@lists.debian.org>
Changed-By: Philipp Kern <pkern@debian.org>
Description: 
 s390-tools - A set of fundamental utilities for Linux on S/390
 s390-tools-udeb - A set of utilities for Linux on S/390 (udeb)
Closes: 599931
Changes: 
 s390-tools (1.14.0-1) unstable; urgency=low
 .
   * New upstream release.
   * Change priority of s390-tools-udeb to the current override value
     `optional'.  It is still pulled in by other installer components.
   * Avoid calling zipl multiple times.  (Closes: #599931)
   * Build hyptop: a utility to monitor the resource usage of other
     guests running on the same LPAR or z/VM hypervisor.
   * Build cmsfs-fuse: userspace filesystem access to z/VM CMS disks.
   * Install chzcrypt, chmem and lsmem.
Checksums-Sha1: 
 99750de7b7ffba24c1cc7e39eab72be45a22c8c5 1367 s390-tools_1.14.0-1.dsc
 945e9b5c9c18fbfbf4f8a7a3eb63ce65c26b605c 598560 s390-tools_1.14.0.orig.tar.bz2
 1161436058e443c351a33b669073a4c416d3c4fc 14549 s390-tools_1.14.0-1.debian.tar.gz
 d8e0a5d1eaf3dd523069c2c510e223f062a32442 433328 s390-tools_1.14.0-1_s390.deb
 b6559eda53664c1cb918ac901cd8b1570713d2f6 43450 s390-tools-udeb_1.14.0-1_s390.udeb
Checksums-Sha256: 
 6f2b234f1c2c8294f0ee0971056529941196c1b56d8d79a76633c65e787ef0c5 1367 s390-tools_1.14.0-1.dsc
 bece7b6f6e787bd4930a288d48bf7048b54a30fd8966af504ae40b12e4fccb9e 598560 s390-tools_1.14.0.orig.tar.bz2
 aae6ab707a94de3a077875b4f4ebfb119a474365784ce4232a23ac3ecbf952c7 14549 s390-tools_1.14.0-1.debian.tar.gz
 3be786e29f9fe803a3cdd0e1f90c6991f70b31f9ea2571521dad110415967354 433328 s390-tools_1.14.0-1_s390.deb
 25c62909b5fd555b860ae99e07a100bfd25067afb44399aa9dd0ee5108d880a1 43450 s390-tools-udeb_1.14.0-1_s390.udeb
Files: 
 03cda5dc0e6b31ee4bba157bbfb09294 1367 admin important s390-tools_1.14.0-1.dsc
 053bb34cd7dcf26a4fef6d1635437f9a 598560 admin important s390-tools_1.14.0.orig.tar.bz2
 9630325b3c86abc98a62488344ad6d64 14549 admin important s390-tools_1.14.0-1.debian.tar.gz
 583903e7bb81ce1061d64c3d5d60c7f5 433328 admin important s390-tools_1.14.0-1_s390.deb
 5621e6f9268f7c2bd19c2ede979f380e 43450 debian-installer optional s390-tools-udeb_1.14.0-1_s390.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEAREIAAYFAk6oIWYACgkQ7Ro5M7LPzdgiQwCeKtB2tNIjzOyK7OW1ENozxQfi
AmQAn2IAFcRynmowEi6hfBEPHJ3zffar
=tIHk
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: