RE: Bug#376159: Open21xx Bug Report

["Keith Clifford" <kcliff@telus.net>]

Good catch. Putting the EOF in the character buffer doesn't sound like a
bright thing to do either. I'll review the whole section and get a release
to you.

Thanks for you help,
Keith

-----Original Message-----
From: Matej Vela [mailto:vela@debian.org] 
Sent: Monday, August 13, 2007 4:37 AM
To: Michel Dänzer
Cc: 376159@bugs.debian.org; Paul Wise; Keith Clifford; debian-powerpc;
debian-s390@lists.debian.org; debian-arm@lists.debian.org
Subject: Re: Bug#376159: Open21xx Bug Report

Michel Dänzer <daenzer@debian.org> writes:

> On Sat, 2007-08-11 at 15:55 +0000, Paul Wise wrote:
>> Looks like it never built/worked on those platforms:
>> 
>> http://buildd.debian.org/build.php?arch=&pkg=open21xx
>> 
>> Hopefully someone on the porter lists will be able to help (CCed).
>> 
>> If no-one replies, I'm willing to use the Debian development machines to
>> help you fix this issue. I'm not familiar with the open21xx source or
>> package, and I have little time for Debian stuff, so I'll need some
>> direction and hints about this.
>
> Given the list of failing architectures, I think the most likely cause
> is some code relying on char being signed by default. And indeed,
> building the as21 directory with -fsigned-char makes it build for me.

You're right, as21/cpp.c was comparing a plain char to EOF.  I've
uploaded the attached patch, let's see if it works.

Thanks,

Matej