[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

ruby-faraday-middleware and its dependency on ruby-safe-yaml



Hi,

some packages are scheduled for autoremoval due to ruby-faraday-middleware
FTBFS. The FTBFS was easy to fix, unfortunately it introduces a dependency on
ruby-safe-yaml. That is suboptimal because I don't think that we can fix ruby-
safe-yaml.

I was playing around with replacing SafeYAML.load() by YAML.safe_load(). That
leaves only the below test issues.

What do you think? Any better idea?

> Failures:
> 
>   1) FaradayMiddleware::ParseYaml SafeYAML options passes relevant options to SafeYAML load
>      Failure/Error:
>        expect(::SafeYAML).to receive(:load)
>          .with(body, nil, options[:parser_options])
>          .and_return(result)
>      
>      NameError:
>        uninitialized constant SafeYAML
>      
>              expect(::SafeYAML).to receive(:load)
>                     ^^^^^^^^^^
>      # ./spec/unit/parse_yaml_spec.rb:65:in `block (3 levels) in <top (required)>'
>      # /usr/share/rubygems-integration/all/gems/webmock-3.18.1/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'
> 
>   2) FaradayMiddleware::ParseYaml no type matching returns false for empty body
>      Failure/Error: expect(process('').body).to be false
>      
>        expected false
>             got nil
>      # ./spec/unit/parse_yaml_spec.rb:10:in `block (3 levels) in <top (required)>'
>      # /usr/share/rubygems-integration/all/gems/webmock-3.18.1/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'
> 
> Finished in 0.30073 seconds (files took 0.33453 seconds to load)
> 260 examples, 2 failures

Regards, Daniel
-- 
Regards,
Daniel Leidert <dleidert@debian.org> | https://www.wgdd.de/
GPG-Key RSA4096 / BEED4DED5544A4C03E283DC74BCD0567C296D05D
GPG-Key ED25519 / BD3C132D8B3805D1808123AB7ACE00941E338C78

https://www.fiverr.com/dleidert
https://www.patreon.com/join/dleidert

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: