Re: RFS: ruby-rack-proxy 0.7.2-1+nmu1

On വ്യാ, ജൂൺ 16 2022 at 04:48:09 വൈകു +0200 +0200, Antoine Le Gonidec <vv221@dotslashplay.it> wrote:

Hi! I’m willing to help with the packaging of Ruby gems required for packaging GitLab for Debian, so here is my first contribution.

thanks for your interest and happy to see the first contribution.

I’m providing the update as two distinct merge requests on Salsa:

- https://salsa.debian.org/ruby-team/ruby-rack-proxy/-/merge_requests/1 targets the "upstream" branch - https://salsa.debian.org/ruby-team/ruby-rack-proxy/-/merge_requests/2 targets the "master" branch

You can just share the fork url as merging more branches is more work and for testing, we have to pull from your fork anyway.

Following the guidelines from https://wiki.debian.org/Teams/Ruby/Packaging#Requesting_Sponsorship, I checked that the package builds cleanly with pbuilder. In addition to the update to the current upstream release, I fixed a couple lintian warnings (not all of them, but I checked that I did not add any new warning). Everything on Salsa CI is green. Since this is my first contribution to the Ruby team, feel free to report anything that I might have done wrong or in an unusual way. I have very little experience with Debian packaging (and none at all with Ruby gems), so I might have missed things that could seem obvious. If everything seems OK, I would like to get a sponsor for: ruby-rack-proxy 0.7.2-1+nmu1

You can keep note of the suggestions shared in irc. I have uploaded it. Thanks for your contribution.

I tested ruby-webpacker using ruby-team/meta on salsa scripts and it looks good. so we can reupload to unstable when this version of gitlab is uploaded.

I recommend using build script from meta repo and running tests for reverse dependencies, especially for potentially breaking changes (using semver.org as a baseline).

Thanks you!