On Sat, Nov 5 2022 at 05:51:32 PM +05:30:00 +05:30:00, Vinay Keshava <vinaykeshava@aol.com> wrote:
On 31/10/22 17:14, Vinay Keshava wrote:Hello Team,I have updated ruby-toml-rb (2.1.0 -> 2.2.0) and ruby-marginalia (1.11.1 | 1.10.1) .The updated package is available at [0] and [1] Reason for sending an RFS mail is that the package is listed in this issue https://git.fosscommunity.in/debian-ruby/TaskTracker/-/issues/191 , so it will help in packaging gitlab 15.5.1.I could not push to https://salsa.debian.org/ruby-team/ruby-marginalia because the branches were protectedshould i remove it ?remote: GitLab: You are not allowed to push code to protected branches on this project.To salsa.debian.org:ruby-team/ruby-marginalia.git ! [remote rejected] master -> master (pre-receive hook declined)! [remote rejected] pristine-tar -> pristine-tar (pre-receive hook declined)! [remote rejected] upstream -> upstream (pre-receive hook declined)! [remote rejected] upstream/1.11.1 -> upstream/1.11.1 (pre-receive hook declined)[0] https://salsa.debian.org/ruby-team/ruby-toml-rb
Uploaded, thanks!
[1] https://salsa.debian.org/vinay-keshava/ruby-marginalia/
I have given you maintainer access for this repo and you should be able to push now. I have also pulled your changes and uploaded it.
I have also updated ruby-rack-proxy to 0.7.4 [2] https://salsa.debian.org/ruby-team/ruby-rack-proxy
Did you verify if it breaks its reverse dependency ruby-webpacker?In this specific case, it seems ruby-webpacker is already broken with ruby 3.1, so we can probably ignore it, but in future verify if breaking changes (as per semver.org) breaks other packages and follow https://wiki.debian.org/Teams/Ruby/Packaging/#Updating_packages_with_API_breaking_changes (give your reasoning why you think it is appropriate to upload it to unstable).
Additionally the dependency in ruby-webpacker seems very loose s.add_dependency "rack-proxy", ">= 0.6.1"I have uploaded it since ruby-webpacker is already broken and dependency is loose.