[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ruby-pg-query_1.3.0-1_amd64.changes REJECTED




On 2021, ഏപ്രിൽ 5 5:33:14 AM IST, Sean Whitton <spwhitton@spwhitton.name> wrote:
>Hello Pirate,
>
>On Mon 29 Mar 2021 at 11:50PM +0530, Pirate Praveen wrote:
>
>>>> +----------------------+
>>>> |    Other comments    |
>>>> +----------------------+
>>>>
>>>> A huge amount of uncompiled source code is installed into /usr/lib;
>>>> shouldn't it be in /usr/share, and installed arch:all?
>>>
>>> These are used during build. Its upstream build system downloads
>>> these sources during build. I have patched its build system to use
>>> the sources provided as extra tarball. I had to include these files
>>> in list of files in gemspec for the build to find these files. I will
>>> need help from ruby team to exclude these in the binary package.
>>>
>>> At least right now, the default is to include all files belonging to
>>> a gem in a single directory, either arch specific directory or arch
>>> independent directory. I don't think we can mix directories for same
>>> gem.
>>>
>>> Ruby team, any ideas on the best method here? If we don't add it to
>>> gemspec's list of files, it won't build and if we remove the files in
>>> deb, we will have a broken gemspec file.
>>>
>>
>> Can you accept the package and file a bug with appropriate severity so
>> we can tackle this later? We could not yet find a good way to solve
>> this and I don't think it is worthy of a reject.
>
>Changing arch:any->arch:all is not an ordinary change and might require
>going through NEW again, so I don't think this should be accepted in its
>current state.
>
Okay removed these source files from the binary package and re-uploaded. This would leave the gemspec file a bit inconsistent, but I think that is a minor issue.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.


Reply to: