[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

RFC: Split autopkgtest-pkg-ruby



Hi there,

I'd like to propose a minor change to how the automatic tests are created and
run in autopkgtest. By adding Testsuite: autopkgtest-pkg-ruby we enable some
automatically created autopkgtests. These are defined in the autodep8 package
in /usr/share/autodep8/support/ruby/. This creates debian/tests/control which
only runs gem2deb-test-runner trying to run the basic dependency check and (if
existent) the debian/ruby-tests.* files.
Check /usr/share/autodep8/support/ruby/generate.

I'm not so happy because the tests are makred skippable and result in return
code 77 which is interpreted as a failure by autopkgtest thus making e.g. the
team's build script stop and not run the reverse-build tests.

I think we should create two tests:

1) Run `gem2deb-test-runner -c` if a gemspec is available and mark the test
superficial, not skippable. Either return 0 if successful or anything else if
not, but never 77. IMHO this is semantically correct. These are just smoke
tests. IMHO some of you also participated in the discussion on debian-devel
about marking such tests superficial.

2) Run the autopkgtests `gem2deb-test-runner --autopkgtest` if any of the
debian/ruby-tests.* files is present.

And of course package maintainers are still free to add more tests in
debian/tests/control.

Let's get rid of this return code 77.

Comments?

Regards, Daniel
-- 
Regards,
Daniel Leidert <dleidert@debian.org> | https://www.wgdd.de/
GPG-Key RSA4096 / BEED4DED5544A4C03E283DC74BCD0567C296D05D
GPG-Key ED25519 / BD3C132D8B3805D1808123AB7ACE00941E338C78

If you like my work consider sponsoring me via
https://www.patreon.com/join/dleidert

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: