[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ruby-js-regex 3.4.0-1




On 8/27/20 6:31 PM, Pirate Praveen wrote:

On 2020, ഓഗസ്റ്റ് 27 12:02:56 PM IST, Cocoa <cocoa1231@disroot.org> wrote:
On 8/27/20 2:58 AM, Pirate Praveen wrote:
On 2020, ഓഗസ്റ്റ് 26 7:38:31 PM IST, Cocoa <cocoa1231@disroot.org> wrote:
Hi,

The following packages are ready to be uploaded (I also verified the
points listed onhttp://wiki.debian.org/Teams/Ruby/Packaging#Requesting_Sponsorship).

Could you please sponsor them?

   ruby-js-regex 3.4.0-1
You need to verify the dependencies in debian/control is in sync with the gemspec file for each update. Minimum versions required may change, old dependencies may get removed or new dependencies may get added. In this case you need to update minimum version required for ruby-character-set.
I've updated the minimum version for ruby-character-set to 1.4 and
ruby-regexp-parser to 1.5 as specified in the gemspec and pushed the
I'll check.

changes. I checked the remaining dependencies, and there are two
development dependencies, namely mutant-rspec (>= 0.1) and codecov (>=
0.8), that aren't yet packaged. Should I add those too? I can package
those two and then add them if that's alright.
We don't need to package every development dependency, only those required for functional tests need to be packaged. So mutant-rspec may be used in tests, codecov could be ignored. But currently tests are not enabled. You can try to include tests by switching to github tarballs in watch file and then enable tests.
Okay. So should I try to redo it from the github tarball? I've already pushed the changes, so the latest commits by me would have to be reverted and the package redone.

Regards
Cocoa (She/Her)



Reply to: