Am Dienstag, den 07.04.2020, 00:43 -0700 schrieb Piper McCorkle: > On 4/6/20 7:27 AM, Antonio Terceiro wrote: > > Otherwise it looks good to me modulo the points that Daniel > > already raised. > > I believe I've resolved those issues, and have pushed the changes to > my fork [1]. I'm CCing Sebastian for review as they uploaded this > package in the past. Thank you all so much for the feedback! > > [1]: https://salsa.debian.org/pmc-guest/ruby-build I see a few remaining issues. - d/copyright needs an update for upstream (check out the copyright notice in LICENSE). - I guess you should add yourself to the copyright for debian/* too. - debian/.gitattributes is still missing. dh-make-ruby will create it for you (remove the created file debian/ruby-tests.rake). I'm not sure how I feel about the tests in test/. They require the bats package. It seems some of these tests are not useful for us and at least two are failing here. I'd guess that these tests could (or should?) be enabled in autopkgtest only (using debian/tests/control) and carefully checked if they are necessary. If you need assistance please don't hesitate to contact this list or join the #ruby-team IRC channel. BTW: We usually build in clean chroots, either using sbuild or pbuilder. Therefor there shouldn't be a need to add debian/.gitignore. Also if you need it, add it to debian/.gitattributes. You can setup a build environment using this script: https://salsa.debian.org/ruby-team/meta/-/blob/master/setup ... and build using this script: https://salsa.debian.org/ruby-team/meta/-/blob/master/build Keep up the good work! Regards, Daniel
Attachment:
signature.asc
Description: This is a digitally signed message part