[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ruby-nokogiri



Hi Utkarsh,

On Fri, Jan 04, 2019 at 01:49:10AM +0530, Utkarsh Gupta wrote:
> Hi,I've updated the Debian package of the Ruby gem *nokogiri*. The
> package wastested on sbuild and was successfully built. It was also
> lintian clean.
> I've updated the package in the salsa repo which may be found at
> https://salsa.debian.org/ruby-team/ruby-nokogiri
> This was listed under "Patch Updates" for diaspora, which may be found at
> https://git.fosscommunity.in/debian-ruby/TaskTracker/issues/133

> Please consider to review and upload it.

I had a quick look at the package ruby-nokogiri. There is something a
bit akward with the new gem version 1.9.1 as upstream does not ship the
test directory.

Could you please ask upstream to reinclude the tests in the gem?

Another possibility is to use the git repository on Github as the source
by changing the debian/watch file (see the manpage of uscan for
example). But again there are some subtleties:

- the git repo contains jar files that neeed to be filtered out from the
  created tar ball, with the Files-Excluded: command in the copyright
  file
- the git repo does not contain any gemspec (on purpose, upstream
  explained it several times). This would break rubygems integration and
  dependency checks for reverse dependencies.
  But one could be added manually (from the gem) or programmatically.

I started about a week ago to go with the github path, but didn't
finish. I will push my changes to a branch 'boutil' if you want to look at
it and either start from there or take some inspiration.

Cheers,

Cédric

Attachment: signature.asc
Description: PGP signature


Reply to: