[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Pkg-javascript-devel] Need help with building vendor/autoprefixer.js for ruby-autoprefixer-rais

On വ്യാ, ഫെബ്രു 7, 2019 at 3:48 വൈകു, Jonas Smedegaard <jonas@jones.dk> wrote:
Quoting Pirate Praveen (2019-02-07 09:33:33)
This was working fine before, I think its breaking now with nodejs 10
 (guess because of reference to buffer in the error and remembering
 some discussions around it).

Can someone help with this error? I tried adding node-buffer as build
 dependency, but that did not change anything.

For others reading along (because I learned on irc that Praveen wants to
continue maintain the wrong approach):

It is bad and wrong and unsurprising it falls apart to try to "build"
vendor/autoprefixer.js - as its path clearly indicates, that is
convenience code copy from a _different_ upstream project.

Source package is node-autoprefixer, not ruby-autoprefixer-rails. Proper thing to do is to have node-autoprefixer build not only targeted Node.js
but also targeted browsers, and then have ruby-autoprefixer-rails
symlink and depend on that.

...as has been pointed out numerous times already for those ruby
packages embedding JavaScript!

I agree the original approach was not the best. The requirement of providing source was met by build depending on node-autoprefixer and generating this file during ruby-autoprefixer-rails build (this meant there was extra effort required to rebuild when node-autoprefixer changes). But I agree, it is better to build this in node-autoprefixer itself, even though upstream does distribute the built file in autoprefixer node module.

But node-autoprefixer is not building any more (even the original build), it fails with this error.

$ sbuild
dh clean
  debian/rules override_dh_auto_clean
make[1]: Entering directory '/home/pravi/forge/debian/git/js-team/node-autoprefixer'
gulp clean
[16:26:50] Local gulp not found in ~/forge/debian/git/js-team/node-autoprefixer
[16:26:50] Try running: npm install gulp
[16:26:50] Using globally installed gulp
   throw err;

Error: Cannot find module 'fs-extra'
   at Function.Module._resolveFilename (module.js:547:15)
   at Function.Module._load (module.js:474:25)
   at Module.require (module.js:596:17)
   at require (internal/module.js:11:18)
at Object.<anonymous> (/home/pravi/forge/debian/git/js-team/node-autoprefixer/gulpfile.js:3:14)
   at Module._compile (module.js:652:30)
   at Object.Module._extensions..js (module.js:663:10)
   at Module.load (module.js:565:32)
   at tryModuleLoad (module.js:505:12)
   at Function.Module._load (module.js:497:3)
make[1]: *** [debian/rules:23: override_dh_auto_clean] Error 1
make[1]: Leaving directory '/home/pravi/forge/debian/git/js-team/node-autoprefixer'
make: *** [debian/rules:9: clean] Error 2

I noticed node-fs-extra is using /usr/lib/nodejs

$ apt-file list node-fs-extra
node-fs-extra: /usr/lib/nodejs/fs-extra/lib/__tests__/promise.test.js

Shouldn't this be fixed in node-fs-extra?

Reply to: