[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Ready for review and looking for sponsor for ruby-websocket package



Uploaded a while ago, I forgot to notify the list.

Thanks for your contribution.

Regards.


On 05/23/2018 01:18 PM, Manas Kashyap wrote:
I have made the corrections , can anyone now , review it and upload it 

On Tue, May 22, 2018 at 7:37 PM, Lucas Kanashiro <kanashiro@debian.org> wrote:

Another minor issue that I missed: the Homepage field in d/control should use https:// instead of http://

Try to avoid commits message with commas left, such as:

"clean and sbuild passed ,"


On 05/18/2018 12:44 PM, Manas Kashyap wrote:
I have made the changes and is available under salsa.debian.org/ruby-team/ruby-websocket , please review it , and upload it 

On Sun, May 13, 2018 at 11:35 PM, Lucas Kanashiro <kanashiro@debian.org> wrote:

Hi,


On 05/13/2018 11:36 AM, Manas Kashyap wrote:
Hola ,   

I am Manas kashyap , a Debian contributor , i have packaged ,
ruby-websocket
(https://salsa.debian.org/Manas-kashyap-guest/ruby-websocket) . and , I
need a sponsor for this package as , this package was packaged for kali
but wasn't available for Debian , so , i packaged it and need someone to
sponsor my package .

If you want to maintain it under the umbrella of Ruby team, you should host it in ruby-team group. I created a repository for you (I saw that you already are a member of our group) to push your work: https://salsa.debian.org/ruby-team/ruby-websocket

Despite that I have a small comment about your work:

You can improve your package description. The short description should not start with "It is...", maybe something like "Ruby library to handle WebSocket protocol". Moreover, your long description should not start with a dot (dot means you want to start a new paragraph), so remove this dot from the beginning of it please. FYI lintian warns about it:

W: ruby-websocket: description-starts-with-leading-spaces

Fix those things and we can upload your package :)

Regards,
Lucas Kanashiro.






Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: