Re: ruby 2.5 sysconfdir and others wrong
On Tue, 2018-03-06 at 12:47 -0300, Antonio Terceiro wrote:
> On Tue, Mar 06, 2018 at 01:49:29PM +0000, John Leach wrote:
> > On Tue, 2018-03-06 at 09:17 -0300, Antonio Terceiro wrote:
> > > On Mon, Mar 05, 2018 at 08:16:01PM +0000, John Leach wrote:
> > > > On Sun, 2018-03-04 at 13:50 -0300, Antonio Terceiro wrote:
> > > > >
> > > > > Thanks for raising this.
> > > > >
> > > > > ruby2.3 used dh_auto_configure, while ruby2.5 calls
> > > > > ./configure
> > > > > directly
> > > > > due to some incompatibilities between dh_auto_configure in
> > > > > debhelper
> > > > > compatibility level 10+ and the way multi-arch is handled in
> > > > > Ruby
> > > > > upstream. Those paths are usually passed in to ./configure by
> > > > > dh_auto_configure, but are missing from the direct call to
> > > > > /configure.
> > > > >
> > > > > I have just uploaded ruby2.5 2.5.0-6 fixing this.
> > > >
> > > > Hi Antonio,
> > > >
> > > > thanks for that, but your patch seems to be adding in a --
> > > > runstatedir
> > > > flag to configure and that doesn't look supported by ruby (
> > > > --localstatedir and --sysconfdir are though)
> > > >
> > > > Is that a mistake or am I misunderstanding something?
> > >
> > > Good question. There is a runstatedir entry in RbConfig::CONFIG,
> > > but
> > > indeed configure does how who a corresponding --runstatedir.
> > > --runstatedir is a commonly-accepted flag in autotools-based
> > > project,
> > > however.
> > >
> > > I'm not sure how this ends up in rbconfig, or if my passing
> > > --runstatedir has any effect at all. I would need to drop it and
> > > try
> > > again, but that is not a priority for me at the moment.
> >
> > for me it's actually breaking the build:
> >
> > configure: error: unrecognized option: `--runstatedir=/var/run'
> >
> > https://launchpadlibrarian.net/359619234/buildlog_ubuntu-artful-amd
> > 64.r
> > uby2.5_2.5.0-4bbox5~artful1_BUILDING.txt.gz
> >
> > I've removed it to get things building for me. Unsure how (or if?)
> > it's
> > working for Debian, but my build environment is a bit different.
>
> debhelper compat mode 10 enables dh_autoreconf by default, so the
> configure that is executed is not the same configure that comes
> prebuilt
> with the tarball. and AIUI --runstatedir is a standard autoconf flag,
> so
> it becomes available when we rebuild configure locally.
>
> you seem to be doing some backporting, and downgrading the debhelper
> compat level for some reason? Ubuntu artful does have debhelper >= 10
ah ok, thanks for the clarification. I am indeed downgrading the
debhelper, really just so I can build the same package on for several
releases of Ubuntu without modifying the package recipes.
I didn't understand that a different configure is used. Thanks for the
explanation.
John.
--
https://www.brightbox.com
Reply to: