Le 25/08/2017 à 08:10, Cédric Boutillier a écrit : > Hi Philippe, Hi Cédric, > I've had a look at ruby-em-proxy. The package looks fine. Just a few > details: > > > - I am not sure deleting the Gemfile.lock is necessary. Is there a > particular reason for that? I had some problems with rspec version in lock file. it made the build fails. > - there is a deprecation warning when running the specs. You can fix it > and report upstream: > > Using `should` from rspec-expectations' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` with `config.expect_with(:rspec) { |c| c.syntax = :should }` instead. Called from /<<PKGBUILDDIR>>/spec/balancing_spec.rb:25:in `block (3 levels) in <top (required)>'. Corrected. I will post the patch upstream tomorrow morning. > - The specs leave two processes behind, which hang the building process: > > ruby /build/ruby-em-proxy-Qdrjr2/ruby-em-proxy-0.1.9/spec/support/echo_server.rb 127.0.0.1 4242 > ruby /build/ruby-em-proxy-Qdrjr2/ruby-em-proxy-0.1.9/spec/support/echo_server.rb /tmp/em-proxy.sock > > please ensure they terminate at the end of the tests. Should be corrected too :-) Cheers, -- O Philippe Thierry. /Y\/ Hardened embedded systems o#o GPG: 7010 9A3C E210 763E 6341 4581 C257 B91B CDAF C1EA
Attachment:
signature.asc
Description: OpenPGP digital signature