[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ruby-fog-xenserver



Hello Praveen,

I have done those changes and pushed it to the repository. Could you please review it.

On Wed, Jan 20, 2016 at 1:39 AM, Pirate Praveen <praveen@onenetbeyond.org> wrote:
On Wednesday 20 January 2016 01:01 AM, sudheesh shetty wrote:
> Hello Praveen,
> Done all the changes you asked, and comitted the changes. Please do
> review it.

1. You missed a section for upstream files (Files: *) above Files: debian/*
2. Check if the license text matches with that of expat (expat is a
variant of MIT, like saffron is a variant of orange) and if it matches,
mention expat.
3. You have to split the copyright text with 80 characters per line
4. Also when it is ready for upload, UNRELEASED in changelog should be
changed to unstable.

> Thanks,
> Sudheesh Shetty




Reply to: