[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: More issues



On Monday 04 January 2016 05:05 PM, Libor Klepáč wrote:
> Hello,
> my co-workers started to use gitlab today and reported some issues :)

Great to see it being used already and thanks for the reports.

> 1) cannot add page
> Upstream has fix:
>  https://github.com/gollum/rugged_adapter/issues/11
> 
> Reported it as:
>   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=809812
> 
> it works with this oneliner.

added the patch and uploaded the package.

> 2) Cannot edit page with non-ascii characters.
> Upstream has no fix yet:
>  https://github.com/gollum/rugged_adapter/issues/5
> 
> This is error from production.log
> Started GET "/xx/xx/wikis/home/edit" for 127.0.0.1 at 2016-01-04 11:54:05 
> +0100
> Processing by Projects::WikisController#edit as HTML
>   Parameters: {"namespace_id"=>"xx", "project_id"=>"xx", "id"=>"home"}
> 
> Encoding::CompatibilityError (incompatible character encodings: UTF-8 and 
> ASCII-8BIT):
>   app/views/projects/wikis/edit.html.haml:17:in 
> `_app_views_projects_wikis_edit_html_haml___2972071715319990883_33865500'
> 
> Completed 500 Internal Server Error in 228ms (Views: 13.9ms | ActiveRecord: 
> 9.7ms)

hopefully, upstream will fix it soon.

> 
> 3) wiki page is not rendered when in markdown format (even simple page without 
> any formating), it renders if in asciidoc.
> There is no error in production.log, so i don't know what is wrong

should be related to previous issue.

> 4) Source files in project cannot be shown, diff in commits cannot be shown
>  this is error from production.log:
> ActionView::Template::Error (undefined method `lfs_pointer?' for 
> #<Gitlab::Git::Blob:0x00000007245110>):
>     29:       %strong
>     30:         = blob.name
>     31:       %small
>     32:         = number_to_human_size(blob_size(blob))
>     33:       .file-actions.hidden-xs
>     34:         = render "actions"
>     35:     - if blob.lfs_pointer?
>   app/helpers/blob_helper.rb:78:in `blob_size'
>   app/views/projects/blob/_blob.html.haml:32:in 
> `_app_views_projects_blob__blob_html_haml___3455717902915098147_60285320'
>   app/views/projects/blob/show.html.haml:7:in 
> `_app_views_projects_blob_show_html_haml__1310854973757963326_59937920'
> 
> I guess, it's somehow related to possibility to directly edit files from web, 
> i have disabled this calls in views and it works for us now

I got in touch with upstream and they pointed out
https://gitlab.com/gitlab-org/gitlab_git/compare/v7.2.20...v7.2.21

I have uploaded ruby-gitlab-git 7.2.22 to archive.

> With regards.
> Libor
> 


Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: