[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ruby-gettext, ruby-solve, ruby-mixlib-archive, test-kitchen



Hi Hleb,

On Mon, Aug 15, 2016 at 02:52:10PM +0300, Hleb Valoshka wrote:
> Hi team!
>
> Kindly reminding that I've pushed the following packages for review and upload.
>
> * ruby-gettext (updated to the latest upstream version)
> * ruby-solve (like above)
> * ruby-mixlib-archive (a new package, dependency for berkshelf ITP)

uploaded these three

> * test-kitchen (a new package)

judging by the amount of patches, this seems to be a reasonably problematic
package! :-o

lib/vendor/hash_recursive_merge.rb is not properly namespaced. it is also under
a different license than the rest of the package; this needs to be mentioned in
dbeian/copyright

debian/copyright is missing entries for at least these copyright
holders::

lib/vendor/hash_recursive_merge.rb:11:# Copyright::   2007-2008 The Authors
lib/kitchen/provisioner/shell.rb:5:# Copyright (C) 2013, Chris Lundquist

lib/kitchen/command/exec.rb:5:# Copyright (C) 2014, HiganWorks LLC
lib/kitchen/provisioner/chef_apply.rb:5:# Copyright (C) 2015, HiganWorks LLC
lib/kitchen/verifier/shell.rb:5:# Copyright (C) 2015, HiganWorks LLC
spec/kitchen/provisioner/chef_apply_spec.rb:5:# Copyright (C) 2015, HiganWorks LLC
spec/kitchen/verifier/shell_spec.rb:5:# Copyright (C) 2015, HiganWorks LLC

lib/kitchen/driver/proxy.rb:5:# Copyright:: Copyright (c) 2013 Opscode, Inc.

spec/kitchen/transport_spec.rb:5:# Copyright (C) 2014, Matt Wrock
spec/kitchen/transport/winrm_spec.rb:5:# Copyright (C) 2014, Matt Wrock

spec/kitchen/provisioner/chef/policyfile_spec.rb:5:# Copyright (C) 2016, Noah Kantrowitz

lib/kitchen/transport/base.rb:6:# Copyright (C) 2014, Salim Afiune
lib/kitchen/transport/dummy.rb:5:# Copyright (C) 2013, Salim Afiune
lib/kitchen/transport.rb:5:# Copyright (C) 2014, Salim Afiune
lib/kitchen/transport/winrm.rb:7:# Copyright (C) 2014, Salim Afiune

debian/rules has some commented boilerplate. Also, it would be nice to enable
dependency resolution during the build.

Attachment: signature.asc
Description: PGP signature


Reply to: