On Wednesday 30 December 2015 03:42 AM, Libor Klepáč wrote: > Helo, > first of all, I want to thank you for your hard work on packaging gitlab for > Debian. > I installed it from ~praveen repo to migrate from packages generated from > packager.io > > I want to share some problems I encountered, i hope it don't come from this > migration, because it's packaged a little differently. Thanks for your feedback. I'll try to fix the problems you reported. > I had to upgrade system from Wheezy to Jessie and than to Stretch. > > 1) init script wants to run daemons under user "git" which (i believe) is not > created by this package Are you sure about it? The values in /etc/init.d/gitlab are overridden by /etc/default/gitlab and app_user is set to gitlab by default in debian. I can see only gitlab user running processes. $ ps aux |grep git gitlab 10408 50.3 37.5 600628 197076 ? Sl 09:08 0:36 unicorn_rails master -D -c /usr/share/gitlab/config/unicorn.rb -E production gitlab 10428 1.0 0.6 45492 3552 ? S 09:09 0:00 /usr/bin/python /usr/lib/ruby/vendor_ruby/pygments/mentos.py gitlab 10444 0.0 37.3 600628 195812 ? Sl 09:09 0:00 unicorn_rails worker[0] -D -c /usr/share/gitlab/config/unicorn.rb -E production gitlab 10447 0.0 37.3 600628 195812 ? Sl 09:09 0:00 unicorn_rails worker[1] -D -c /usr/share/gitlab/config/unicorn.rb -E production gitlab 10450 0.0 37.3 600628 195812 ? Sl 09:09 0:00 unicorn_rails worker[2] -D -c /usr/share/gitlab/config/unicorn.rb -E production gitlab 10468 0.2 0.3 113268 1728 ? Ssl 09:09 0:00 gitlab-workhorse -listenUmask 0 -listenNetwork unix -listenAddr /usr/share/gitlab/tmp/sockets/gitlab-workhorse.socket -authBackend http://127.0.0.1:8080 gitlab 10541 94.2 10.7 209920 56212 ? Rl 09:09 0:06 /usr/bin/ruby /usr/bin/sidekiq -q post_receive -q mailers -q archive_repo -q system_hook -q project_web_hook -q gitlab_shell -q incoming_email -q runner -q common -q default -e production -P /usr/share/gitlab/tmp/pids/sidekiq.pid -d -L /usr/share/gitlab/log/sidekiq.log praveen 10550 0.0 0.1 12672 1024 pts/6 S+ 09:09 0:00 grep git > 2) init script doesn't work with systemd (some problem with policykit, when it > tries to su to user git) Created an issue to track this https://gitlab.com/debian-ruby/TaskTracker/issues/55 (we can move this to bts once gitlab enters the archive - currently in NEW) > 3) package doesn't migrate DB but creates new empty database in rake-tasks That is in the TODO list https://gitlab.com/debian-ruby/TaskTracker/issues/52 > 4) package gitlab-shell doesn't contain /usr/share/gitlab-shell/hooks > directory - maybe reason of > https://gitlab.com/debian-ruby/TaskTracker/issues/40 > after copying this directory from source package, creation on repository > started to work I have been trying to troubleshoot gitlab-shell issues with help from upstream https://gitlab.com/gitlab-org/gitlab-ce/issues/4773 That was indeed the issue, after including hooks directory I could create repositories. > > 5) weird paths created and expected by gitlab-shell > a) command paths in /usr/share/gitlab/.ssh/authorized_keys point to: > "/usr/lib/ruby/bin/gitlab-shell", i have had to create symlink > btw: authorized_keys should probably be somewhere in /var/lib, because it's > generated ? > > b) i have to generete more symlinks in /usr/lib/ruby to get gitlab-shell > working > ./bin/gitlab-shell -> /usr/share/gitlab-shell/bin/gitlab-shell > ./config.yml -> /usr/share/gitlab-shell/config.yml > ./gitlab-shell.log -> /usr/share/gitlab-shell/gitlab-shell.log > ./.gitlab_shell_secret -> /usr/share/gitlab-shell/.gitlab_shell_secret > ./lib/gitlab_init.rb -> /usr/lib/ruby/vendor_ruby/gitlab_init.rb > ./lib/gitlab_keys.rb -> /usr/lib/ruby/vendor_ruby/gitlab_keys.rb I have fixed the paths in git and package is in ~praveen repo. > c) i some more symlinks in /usr/share/gitlab-shell > ./.gitlab_shell_secret -> /usr/share/gitlab/.gitlab_shell_secret > ./lib/gitlab_init.rb -> /usr/lib/ruby/vendor_ruby/gitlab_init.rb > ./lib/gitlab_shell.rb -> /usr/lib/ruby/vendor_ruby/gitlab_shell.rb This should be fixed as well, please test the new package and confirm. > d) gitlab-shell logs to /usr/share/gitlab-shell/gitlab-shell.log Added to todo list. I will move all logs to /var/log https://gitlab.com/debian-ruby/TaskTracker/issues/56 > > Thanks for your work again, You are welcome! Thanks for your feedback. > with regards, > Libor >
Attachment:
signature.asc
Description: OpenPGP digital signature