Re: RFS: ruby-facade 1.0.7-1, ruby-fix-trinity-output 1.0.0-1, ruby-yell 2.0.5-1, ruby-colorize 0.7.7-1

[Per Andersson <avtobiff@gmail.com>]

On Fri, Oct 9, 2015 at 8:38 PM, Michael Crusoe <michael.crusoe@gmail.com> wrote:
>
> On Oct 9, 2015 07:24, "Antonio Terceiro" <terceiro@debian.org> wrote:
>>
>> On Fri, Oct 09, 2015 at 04:22:33AM +0000, Michael R. Crusoe wrote:
>> > Hello,
>> >
>> > What is the correct procedure to get packages sponsored by the
>> > debian-ruby
>> > team?
>>
>> it is what you did, it's just that nobody had a chance to look at it
>> yet. please be patient.
>
> Understood, my apologies. Still learning the culture in this team.

Welcome! Hope you enjoy it sofar. Please join the (mostly idle?) discussion
on IRC: #debian-ruby @ irc.oftc.net.


> ruby-facade 1.0.7-1
> ruby-yell 2.0.5-1
> ruby-colorize 0.7.7-1

Uploaded all above.


> ruby-fix-trinity-output 1.0.0-1

Fails to build.

---snip---
 debian/rules build
dh build --buildsystem=ruby --with ruby
   dh_testdir -O--buildsystem=ruby
   dh_auto_configure -O--buildsystem=ruby
    dh_ruby --configure
   debian/rules override_dh_auto_build
make[1]: Entering directory '/build/ruby-fix-trinity-output-1.0.0'
dh_auto_build
    dh_ruby --build
   dh_ruby --build
help2man --name "Fix output fastq files from Trinity" \
    --version-string="1.0.0" bin/fix-trinity-output > \
    debian/fix-trinity-output.1
help2man: can't get `--help' info from bin/fix-trinity-output
Try `--no-discard-stderr' if option outputs to stderr
debian/rules:21: recipe for target 'override_dh_auto_build' failed
make[1]: *** [override_dh_auto_build] Error 2
make[1]: Leaving directory '/build/ruby-fix-trinity-output-1.0.0'
debian/rules:18: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
E: Failed autobuilding of package
---snip---


It fails because help2man is used to create the man page during build
and lib is not in the ruby include path so bin/fix-trinity-output can't run.


---snip---
root@saturn:/tmp/buildd/ruby-fix-trinity-output-1.0.0#
bin/fix-trinity-output
/usr/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in
`require': cannot load such file -- fix-trinity-output (LoadError)
    from /usr/lib/ruby/2.1.0/rubygems/core_ext/kernel_require.rb:55:in `require'
    from bin/fix-trinity-output:6:in `<main>'
root@saturn:/tmp/buildd/ruby-fix-trinity-output-1.0.0# ruby -Ilib
bin/fix-trinity-output --help
fix-trinity-output v1.0

Trinity outputs fastq files that have been 'corrected'

Unfortunately these files are no longer properly paired and therefore
can't be used in most aligners such as bowtie2 and snap

This script attempts to fix that and produce 2 properly paired fastq
files and a fastq file containing single reads

Options:
    --left, -l <s>:   fastq file of left reads
   --right, -r <s>:   fastq file of right reads
  --output, -o <s>:   output prefix
        --help, -h:   Show this message
---snip---


I suggest that you create the man page once and save it in the debian
directory.

Please also submit this man page upstream!


Thanks a lot for your work!


--
Per