Hi Richard, > Just wanted to mention that with ruby-monkey-lib there was a missing B-D > on ruby-backports in the source package, and that it's been updated > here: > http://anonscm.debian.org/cgit/pkg-ruby-extras/ruby-monkey-lib.git/ > You can also find ruby-rpam-ruby19 here: > http://anonscm.debian.org/cgit/pkg-ruby-extras/ruby-rpam-ruby.git/ Please find below some comments about ruby-monkey-lib: - you can remove debian/tests/ as it contains only an autogenerated .ex file with some default command - you can remove debian/ruby-monkey-lib.docs as the README.rdoc file doesn't give any information on the library and how to use it. - it is considered generally a good practice to use the same license for the packaging and upstream project. In the debian/copyright file, the Comment: field for the debian/ directory says exactly that, but you use GPL-2+, whereas upstream is BSD-3-clause. Please remove the comment if you have a good reason to keep this license, or switch the license for debian/ to BSD-3-clause. - in debian/control, Testsuite: field should be autopkgtest-pkg-ruby. remove the commented line (mentionning the backport gem). In the descriptions, Ruby should use a capital letter R. Please follow the advice for the short descriptions §6.2.2 in the developers reference. I have hard time making sense out of the long description. Maybe could you improve it a little bit? I know that sometimes it can be hard to understand what a Ruby gem is doing, or how to explain it with simple words... I'll try to review the other package later this week. Cheers, Cédric
Attachment:
signature.asc
Description: Digital signature